Sign upLogin

jumper423/decaptcha

View on GitHub
Star
src/services/RuCaptchaGeeTest.php

Summary

Maintainability
D
2 days
Test Coverage

Method init has 91 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function init()
    {
        parent::init();

        unset(
Severity: Major
Found in src/services/RuCaptchaGeeTest.php - About 3 hrs to fix

    Function decodeResponse has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function decodeResponse($action, $data)
    {
        if (!array_key_exists($action, $this->decodeSettings[static::DECODE_ACTION])) {
            throw new DeCaptchaErrors('нет action');
        }
    Severity: Minor
    Found in src/services/RuCaptchaGeeTest.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused parameters such as '$null'.
    Open

        public function recognize($additionally = [], $null = null)
    Severity: Minor
    Found in src/services/RuCaptchaGeeTest.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    The method decodeResponse uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            foreach (explode($decodeSetting[static::DECODE_SEPARATOR], $data) as $key => $value) {
                foreach ($decodeSetting[static::DECODE_PARAMS] as $param => $paramSetting) {
                    if ($key === $paramSetting[static::DECODE_PARAM_SETTING_MARKER]) {
                        $values[$param] = $value;
    Severity: Minor
    Found in src/services/RuCaptchaGeeTest.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            unset(
            $this->paramsNames[static::ACTION_FIELD_FILE],
            $this->paramsNames[static::ACTION_FIELD_PHRASE],
            $this->paramsNames[static::ACTION_FIELD_REGSENSE],
            $this->paramsNames[static::ACTION_FIELD_NUMERIC],
    Severity: Major
    Found in src/services/RuCaptchaGeeTest.php and 3 other locations - About 1 day to fix
    src/services/RuCaptchaFunCaptcha.php on lines 14..37
    src/services/RuCaptchaKeyCaptcha.php on lines 14..37
    src/services/RuCaptchaReCaptcha.php on lines 14..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 376.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status