Sign upLogin

junebug12851/pokered-save-editor

View on GitHub
Star
src/app/data/savefile-expanded/fragments/PokemonBox.ts

Summary

Maintainability
C
1 day
Test Coverage

Showing 100 of 101 total issues

File PokemonBox.ts has 321 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { SaveFileIterator } from './../SaveFileIterator';
import { SaveFileService } from './../../savefile.service';
import {Pokemon} from '../../../../assets/data/pokemon';
import { GameDataService } from '../../gameData.service';
import { PokemonDBService } from '../../pokemonDB.service';
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts - About 3 hrs to fix

Function load has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    public load(saveFile: SaveFileService,
        startOffset: number,
        nicknameStartOffset: number,
        otNameStartOffset: number,
        index: number,
Severity: Major
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts - About 2 hrs to fix

Function save has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public save(saveFile: SaveFileService,
        startOffset: number,
        speciesStartOffset: number | null,
        nicknameStartOffset: number,
        otNameStartOffset: number,
Severity: Major
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts - About 2 hrs to fix

Function newPokemon has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    static newPokemon(file: SaveFileService, pdb: PokemonDBService, gd: GameDataService) {
        const pkmn = new PokemonBox();
        const pkmnList = gd.file("randomPkmn").data;
        const pkmnData = pdb.pokemon[_.snakeCase(pkmnList[_.random(0, pkmnList.length, false)])];
 
 
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts - About 1 hr to fix

Function newPokemon has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static newPokemon(file: SaveFileService, pdb: PokemonDBService, gd: GameDataService) {
        const pkmn = new PokemonBox();
        const pkmnList = gd.file("randomPkmn").data;
        const pkmnData = pdb.pokemon[_.snakeCase(pkmnList[_.random(0, pkmnList.length, false)])];
 
 
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts - About 1 hr to fix

Function save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public save(saveFile: SaveFileService,
        startOffset: number,
        speciesStartOffset: number | null,
        nicknameStartOffset: number,
        otNameStartOffset: number,
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts - About 45 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            pkmn.moves[i].pp = (pkmnData.initial[i]) ? pkmnData.initial[i].pp : 0;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts and 1 other location - About 30 mins to fix
src/app/data/savefile-expanded/fragments/PokemonBox.ts on lines 62..62

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            pkmn.moves[i].moveID = (pkmnData.initial[i]) ? pkmnData.initial[i].ind : 0;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts and 1 other location - About 30 mins to fix
src/app/data/savefile-expanded/fragments/PokemonBox.ts on lines 63..63

if statements must be braced
Open

        if(this.isValidPokemon === false)
            return this.exp;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

            exp = (1.2 * Math.pow(level, 3)) - (15 * Math.pow(level, 2)) + (100*level) - 140;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((baseStat+dv)*2+Math.floor(Math.floor(Math.sqrt(ev))/4))*this.level)/100) + 5;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((baseStat+dv)*2+Math.floor(Math.floor(Math.sqrt(ev))/4))*this.level)/100) + 5;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((baseStat+dv)*2+Math.floor(Math.floor(Math.sqrt(ev))/4))*this.level)/100) + 5;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(pkmnData.type1 !== undefined)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(pkmnData.type2 !== undefined)
            pkmn.type2 = pkmnData.type2.ind;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

            if(pkmnData.initial == undefined)
                continue;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(pkmnData.catchRate !== undefined)
            pkmn.catchRate = pkmnData.catchRate;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

" should be '
Open

        if(nickname == "NIDORAN<F>")
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

" should be '
Open

        return this.getNonHPStat("baseSpeed", this.dv.speed, this.speedExp);
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((record.baseHp+this.hpDV)*2+Math.floor(Math.floor(Math.sqrt(this.hpExp))/4))*this.level)/100) + this.level + 10;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((record.baseHp+this.hpDV)*2+Math.floor(Math.floor(Math.sqrt(this.hpExp))/4))*this.level)/100) + this.level + 10;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((baseStat+dv)*2+Math.floor(Math.floor(Math.sqrt(ev))/4))*this.level)/100) + 5;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(gr == 0)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(this.isValidPokemon === false)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if((this.dv.speed % 2) !== 0)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(record === false)
            return exp;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(this.level >= 100)
            return 1;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

" should be '
Open

        return this.getNonHPStat("baseSpecial", this.dv.special, this.specialExp);
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        else if(gr == 3)
            exp = (1.2 * Math.pow(level, 3)) - (15 * Math.pow(level, 2)) + (100*level) - 140;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

" should be '
Open

const _ = window.require("lodash");
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

Missing semicolon
Open

            nickname = "NIDORAN<f>"
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((record.baseHp+this.hpDV)*2+Math.floor(Math.floor(Math.sqrt(this.hpExp))/4))*this.level)/100) + this.level + 10;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((baseStat+dv)*2+Math.floor(Math.floor(Math.sqrt(ev))/4))*this.level)/100) + 5;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(pkmnData.type2 !== undefined)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        else if(nickname == "NIDORAN<M>")
            nickname = "NIDORAN<m>"
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        for(let i = 0; i < 4; i++) {
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((baseStat+dv)*2+Math.floor(Math.floor(Math.sqrt(ev))/4))*this.level)/100) + 5;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        else if(gr == 5)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(record === false)
            return 0;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

Identifier 'record' is never reassigned; use 'const' instead of 'let'.
Open

        let record = this.pkmnArr[this.species - 1];
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

" should be '
Open

            nickname = "NIDORAN<m>"
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((record.baseHp+this.hpDV)*2+Math.floor(Math.floor(Math.sqrt(this.hpExp))/4))*this.level)/100) + this.level + 10;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((record.baseHp+this.hpDV)*2+Math.floor(Math.floor(Math.sqrt(this.hpExp))/4))*this.level)/100) + this.level + 10;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((baseStat+dv)*2+Math.floor(Math.floor(Math.sqrt(ev))/4))*this.level)/100) + 5;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

            if(pkmnData.initial == undefined)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(pkmnData.catchRate !== undefined)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if((this.dv.attack % 2) !== 0)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if((this.dv.defense % 2) !== 0)
            hpDv |= 4;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

" should be '
Open

        return this.getNonHPStat("baseAttack", this.dv.attack, this.attackExp);
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if((this.dv.special % 2) !== 0)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(pkmnData.type1 !== undefined)
            pkmn.type1 = pkmnData.type1.ind;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

" should be '
Open

        const pkmnList = gd.file("randomPkmn").data;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

" should be '
Open

            nickname = "NIDORAN<f>"
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(this.isValidPokemon === false)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

            exp = (1.2 * Math.pow(level, 3)) - (15 * Math.pow(level, 2)) + (100*level) - 140;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((record.baseHp+this.hpDV)*2+Math.floor(Math.floor(Math.sqrt(this.hpExp))/4))*this.level)/100) + this.level + 10;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((record.baseHp+this.hpDV)*2+Math.floor(Math.floor(Math.sqrt(this.hpExp))/4))*this.level)/100) + this.level + 10;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(this.level >= 100)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((baseStat+dv)*2+Math.floor(Math.floor(Math.sqrt(ev))/4))*this.level)/100) + 5;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(nickname == "NIDORAN<F>")
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(speciesStartOffset !== null) {
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(this.isValidPokemon === false)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(pkmn.type1 == pkmn.type2)
            pkmn.type2 = 0xFF;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        else if(gr == 4)
            exp = (4 * Math.pow(level, 3)) / 5
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(this.isValidPokemon === false)
            return;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if((this.dv.attack % 2) !== 0)
            hpDv |= 8;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((record.baseHp+this.hpDV)*2+Math.floor(Math.floor(Math.sqrt(this.hpExp))/4))*this.level)/100) + this.level + 10;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((baseStat+dv)*2+Math.floor(Math.floor(Math.sqrt(ev))/4))*this.level)/100) + 5;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((baseStat+dv)*2+Math.floor(Math.floor(Math.sqrt(ev))/4))*this.level)/100) + 5;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(record === false)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(gr == 0)
            exp = Math.pow(level, 3);
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        else if(gr == 5)
            exp = (5 * Math.pow(level, 3)) / 4
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if((this.dv.speed % 2) !== 0)
            hpDv |= 2;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

" should be '
Open

        return this.getNonHPStat("baseDefense", this.dv.defense, this.defenseExp);
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

Missing semicolon
Open

            exp = (5 * Math.pow(level, 3)) / 4
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((record.baseHp+this.hpDV)*2+Math.floor(Math.floor(Math.sqrt(this.hpExp))/4))*this.level)/100) + this.level + 10;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        else if(gr == 3)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        else if(gr == 4)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(this.isValidPokemon === false)
            return this.exp;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(record === false || record.baseHp == undefined)
            return 1;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((record.baseHp+this.hpDV)*2+Math.floor(Math.floor(Math.sqrt(this.hpExp))/4))*this.level)/100) + this.level + 10;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if((this.dv.defense % 2) !== 0)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(nickname == "NIDORAN<F>")
            nickname = "NIDORAN<f>"
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if((this.dv.special % 2) !== 0)
            hpDv |= 1;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

" should be '
Open

        else if(nickname == "NIDORAN<M>")
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        else if(nickname == "NIDORAN<M>")
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(this.isValidPokemon === false)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

Identifier 'record' is never reassigned; use 'const' instead of 'let'.
Open

        let record = this.isValidPokemon;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((baseStat+dv)*2+Math.floor(Math.floor(Math.sqrt(ev))/4))*this.level)/100) + 5;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(pkmn.type1 == pkmn.type2)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(record == undefined || record.pokedex == null || record.pokedex == undefined)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(record === false)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(record == undefined || record.pokedex == null || record.pokedex == undefined)
            return false;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

if statements must be braced
Open

        if(this.isValidPokemon === false)
            return 0;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

" should be '
Open

        this.pkmnArr = this.gd.file("pokemon").data;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

Missing semicolon
Open

            nickname = "NIDORAN<m>"
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((record.baseHp+this.hpDV)*2+Math.floor(Math.floor(Math.sqrt(this.hpExp))/4))*this.level)/100) + this.level + 10;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

Missing semicolon
Open

            exp = (4 * Math.pow(level, 3)) / 5
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((record.baseHp+this.hpDV)*2+Math.floor(Math.floor(Math.sqrt(this.hpExp))/4))*this.level)/100) + this.level + 10;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        return Math.floor((((baseStat+dv)*2+Math.floor(Math.floor(Math.sqrt(ev))/4))*this.level)/100) + 5;
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint

missing whitespace
Open

        if(record === false || record.baseHp == undefined)
Severity: Minor
Found in src/app/data/savefile-expanded/fragments/PokemonBox.ts by tslint
Category
Status