junebug12851/pokered-save-editor

View on GitHub
src/app/data/savefile-expanded/fragments/SpriteData.ts

Summary

Maintainability
A
0 mins
Test Coverage

Showing 44 of 44 total issues

if statements must be braced
Open

if (val.missableIndex === null || !(val.missableIndex >= 0))
continue;

if statements must be braced
Open

if (mId == 0xFF)
break;

Declaration of static method not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface.
Open

static saveMissables(saveFile: SaveFileService, spriteData: SpriteData[]) {
const it = saveFile.iterator;
 
it.offsetTo(0x287A);
for (let i = 0; i < spriteData.length && i < 16; i++) {

if statements must be braced
Open

if (mId !== index)
continue;

Missing semicolon
Open

it.setByte(this.faceDir)

Type number trivially inferred from a number literal, remove type annotation
Open

public yStepVector: number = 0;

Missing semicolon
Open

it.setByte(this.movementStatus)

Missing semicolon
Open

it.setByte(this.intraAnimationFrameCounter)

Type number trivially inferred from a number literal, remove type annotation
Open

public yPixels: number = 0;

Missing semicolon
Open

it.setByte(this.yStepVector)

Missing semicolon
Open

it.setByte(this.xStepVector)

Missing semicolon
Open

it.setByte(this.mapX)

if statements must be braced
Open

if ((typeof savefile === "object") && savefile !== null)
this.load(savefile as SaveFileService, index as number);

Type number trivially inferred from a number literal, remove type annotation
Open

public xDisp: number = 0;

Type number trivially inferred from a number literal, remove type annotation
Open

public mapY: number = 0;

Missing semicolon
Open

it.setByte(this.movementByte)

Type number trivially inferred from a number literal, remove type annotation
Open

public intraAnimationFrameCounter: number = 0;

Missing semicolon
Open

it.setByte(this.grassPriority)

comment must start with a space
Open

//(-1, 0 or 1)

Type number trivially inferred from a number literal, remove type annotation
Open

public pictureID: number = 0;

Missing semicolon
Open

it.setByte(this.yPixels)

Missing semicolon
Open

it.setByte(this.yDisp)

Type number trivially inferred from a number literal, remove type annotation
Open

public faceDir: number = 0;

Type number trivially inferred from a number literal, remove type annotation
Open

public walkAnimationCounter: number = 0;

Type number trivially inferred from a number literal, remove type annotation
Open

public grassPriority: number = 0;

" should be '
Open

if ((typeof savefile === "object") && savefile !== null)

Missing semicolon
Open

it.setByte(this.imageBaseOffset)

comment must start with a space
Open

//(-1, 0 or 1)

Type number trivially inferred from a number literal, remove type annotation
Open

public yDisp: number = 0;

Type number trivially inferred from a number literal, remove type annotation
Open

public movementByte: number = 0;

Type number trivially inferred from a number literal, remove type annotation
Open

public movementDelay: number = 0;

Type number trivially inferred from a number literal, remove type annotation
Open

public imageIndex: number = 0;

Type number trivially inferred from a number literal, remove type annotation
Open

public imageBaseOffset: number = 0;

Missing semicolon
Open

it.setByte(this.animFrameCounter)

Type number trivially inferred from a number literal, remove type annotation
Open

public xStepVector: number = 0;

Type number trivially inferred from a number literal, remove type annotation
Open

public animFrameCounter: number = 0;

Missing semicolon
Open

it.setByte(this.pictureID)

Missing semicolon
Open

it.setByte(this.imageIndex)

Missing semicolon
Open

it.setByte(this.xDisp)

Type number trivially inferred from a number literal, remove type annotation
Open

public movementStatus: number = 0;

Type number trivially inferred from a number literal, remove type annotation
Open

public mapX: number = 0;

Missing semicolon
Open

it.setByte(this.xPixels)

Missing semicolon
Open

it.setByte(this.mapY)

Type number trivially inferred from a number literal, remove type annotation
Open

public xPixels: number = 0;
Category
Status