junebug12851/pokered-save-editor

View on GitHub
src/app/data/savefile-expanded/sections/Area/AreaTileset.ts

Summary

Maintainability
A
0 mins
Test Coverage

Showing 25 of 25 total issues

" should be '
Open

const curTileset = saveFile.getHex(0x2613, 0x1).padStart(2, "0").toUpperCase();

" should be '
Open

tilesetTalkingOverTiles[0].toString(16).padStart(2, "0").toUpperCase(),

" should be '
Open

public tileFrontBoulderColl: string = "00";

" should be '
Open

this.tilesetType = saveFile.getByte(0x3522).toString(16).padStart(2, "0").toUpperCase();

" should be '
Open

public tileset: string = "00_00_0000_0000_0000";

" should be '
Open

const tilesetBlockPtr = saveFile.getWord(0x27D8, true).toString(16).padStart(4, "0").toUpperCase();

" should be '
Open

const tilesetBank = saveFile.getHex(0x27D7, 0x1).padStart(2, "0").toUpperCase();

Type number trivially inferred from a number literal, remove type annotation
Open

public boulderSpriteIndex: number = 0;

" should be '
Open

this.tilesetGrassTile = saveFile.getByte(0x27E1).toString(16).padStart(2, "0").toUpperCase();

if statements must be braced
Open

if (saveFile !== undefined)
this.load(saveFile as SaveFileService);

Type string trivially inferred from a string literal, remove type annotation
Open

public tileset: string = "00_00_0000_0000_0000";

" should be '
Open

public tilesetType: string = "00";

Type string trivially inferred from a string literal, remove type annotation
Open

public tilesetType: string = "00";

" should be '
Open

this.outOfBoundsTile = saveFile.getHex(0x2659, 0x1).padStart(2, "0").toUpperCase();

" should be '
Open

tilesetTalkingOverTiles[2].toString(16).padStart(2, "0").toUpperCase(),

" should be '
Open

const tilesetArr = this.tileset.split("_");

" should be '
Open

public tilesetGrassTile: string = "00";

" should be '
Open

const tilesetCollPtr = saveFile.getWord(0x27DC, true).toString(16).padStart(4, "0").toUpperCase();

" should be '
Open

public outOfBoundsTile: string = "00";

Type string trivially inferred from a string literal, remove type annotation
Open

public outOfBoundsTile: string = "00";

Type string trivially inferred from a string literal, remove type annotation
Open

public tileFrontBoulderColl: string = "00";

" should be '
Open

this.tileFrontBoulderColl = saveFile.getByte(0x29C8).toString(16).padStart(2, "0").toUpperCase();

Type string trivially inferred from a string literal, remove type annotation
Open

public tilesetGrassTile: string = "00";

" should be '
Open

const tilesetGfxPtr = saveFile.getWord(0x27DA, true).toString(16).padStart(4, "0").toUpperCase();

" should be '
Open

tilesetTalkingOverTiles[1].toString(16).padStart(2, "0").toUpperCase(),
Category
Status