Sign upLogin

junebug12851/pokered-save-editor

View on GitHub
Star
src/app/data/savefile.service.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Showing 41 of 41 total issues

SaveFileService has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

@Injectable({
    providedIn: 'root'
})
export class SaveFileService {
 
 
Severity: Minor
Found in src/app/data/savefile.service.ts - About 2 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        const bank3IndvChecksums = [
            this.getChecksum(0x6000, 0x6462),
            this.getChecksum(0x6462, 0x68C4),
            this.getChecksum(0x68C4, 0x6D26),
            this.getChecksum(0x6D26, 0x7188),
Severity: Major
Found in src/app/data/savefile.service.ts and 1 other location - About 1 hr to fix
src/app/data/savefile.service.ts on lines 302..309

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        const bank2IndvChecksums = [
            this.getChecksum(0x4000, 0x4462),
            this.getChecksum(0x4462, 0x48C4),
            this.getChecksum(0x48C4, 0x4D26),
            this.getChecksum(0x4D26, 0x5188),
Severity: Major
Found in src/app/data/savefile.service.ts and 1 other location - About 1 hr to fix
src/app/data/savefile.service.ts on lines 317..324

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (size > 0)
            for (let i = 1; i < size; i++) {
                res <<= 8;
                res |= value[i];
            }
Severity: Minor
Found in src/app/data/savefile.service.ts and 1 other location - About 40 mins to fix
src/app/data/savefile.service.ts on lines 237..241

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (size > 0)
            for (let i = 1; i < size; i++) {
                res <<= 8;
                res |= value[i];
            }
Severity: Minor
Found in src/app/data/savefile.service.ts and 1 other location - About 40 mins to fix
src/app/data/savefile.service.ts on lines 222..226

Forbidden 'var' keyword, use 'let' or 'const' instead
Open

        var n = 0;
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

" should be '
Open

import { TextService } from "./text.service";
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

Missing semicolon
Open

}
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

Identifier 'value' is never reassigned; use 'const' instead of 'let'.
Open

        let value = this.getRange(from, 2, bigEndian);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

" should be '
Open

        ipcRenderer.on("dataUpdate", this.onDataUpdate.bind(this));
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

else statements must be braced
Open

        else
            while (hexValue > 0) {
                hexArr.push(hexValue & 0xFF);
                hexValue >>= 8;
            }
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

Unnecessary semicolon
Open

        const checksum = new Uint8Array([0xFF]);;
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

if statements must be braced
Open

        if (hexValueOrig <= 0xFF && size == 2)
            hexArr.push(0x00);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

else statements must be braced
Open

        else
            res &= ~(1 << bit);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

if statements must be braced
Open

        if (size > 0)
            for (let i = 1; i < size; i++) {
                res <<= 8;
                res |= value[i];
            }
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

Forbidden 'var' keyword, use 'let' or 'const' instead
Open

        var m = 1;
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

Forbidden 'var' keyword, use 'let' or 'const' instead
Open

        for (var i: number = 0; i < bcd.length; i += 1) {
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

if statements must be braced
Open

        if (val)
            res |= (1 << bit);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

Forbidden 'var' keyword, use 'let' or 'const' instead
Open

        var s = size || 4; //default value: 4
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

missing whitespace
Open

        const checksum = new Uint8Array([0xFF]);;
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

Forbidden 'var' keyword, use 'let' or 'const' instead
Open

        var bcd = new Buffer(s);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

Identifier 'bcd' is never reassigned; use 'const' instead of 'var'.
Open

        var bcd = new Buffer(s);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

comment must start with a space
Open

        var s = size || 4; //default value: 4
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

if statements must be braced
Open

            if (!internalOnly)
                this.fileDataExpanded = new SaveFileExpanded(this);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

" should be '
Open

        ipcRenderer.on("dataChange", this.onDataChange.bind(this));
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

if statements must be braced
Open

        if (prefix)
            hexStr = `0x${hexStr}`;
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

Type number trivially inferred from a number literal, remove type annotation
Open

        for (var i: number = 0; i < bcd.length; i += 1) {
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

" should be '
Open

            ipcRenderer.send("ipcFrom", "dataUpdate", this.fileData, true);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

else statements must be braced
Open

        else
            return this.fileData.subarray(from, from + size);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

if statements must be braced
Open

        if (hexValue === 0)
            hexArr.push(0);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

Identifier 'hexArr' is never reassigned; use 'const' instead of 'let'.
Open

        let hexArr = [];
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

if statements must be braced
Open

        if (boxesFormatted || force)
            this.recalcBoxesChecksums();
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

if statements must be braced
Open

        if (bigEndian)
            data = data.reverse();
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

if statements must be braced
Open

        if (hasPrefix)
            hex = hex.substr(2);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

Identifier 'value' is never reassigned; use 'const' instead of 'let'.
Open

        let value = this.getRange(from, size, bigEndian);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

" should be '
Open

        let hexStr = "";
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

if statements must be braced
Open

        if (bigEndian)
            value = value.reverse();
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

" should be '
Open

            ipcRenderer.send("ipcFrom", "dataUpdate", this.fileData, true);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

if statements must be braced
Open

        if (bigEndian)
            return this.fileData.subarray(from, from + size).reverse();
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

if statements must be braced
Open

        if (size > 0)
            for (let i = 1; i < size; i++) {
                res <<= 8;
                res |= value[i];
            }
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

Identifier 'rawHex' is never reassigned; use 'const' instead of 'let'.
Open

        let rawHex = this.getRange(from, size, bigEndian);
Severity: Minor
Found in src/app/data/savefile.service.ts by tslint

There are no issues that match your filters.

Category
Status