Sign upLogin

junebug12851/pokered-save-editor

View on GitHub
Star
src/app/fragments/select-map-width/select-map-width.component.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Showing 23 of 23 total issues

Function mapList has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    get mapList() {
 
        const maps: Map[] = this.gd.file("maps").data;
 
        const b = (val: number | any) => {
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts - About 1 hr to fix

Function mapList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    get mapList() {
 
        const maps: Map[] = this.gd.file("maps").data;
 
        const b = (val: number | any) => {
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts - About 25 mins to fix

Similar blocks of code found in 20 locations. Consider refactoring.
Open

@Component({
    selector: 'select-map-width',
    templateUrl: './select-map-width.component.pug',
    styleUrls: ['./select-map-width.component.scss'],
    providers: [
Severity: Major
Found in src/app/fragments/select-map-width/select-map-width.component.ts and 19 other locations - About 40 mins to fix
src/app/fragments/connection-item/connection-item.component.ts on lines 25..48
src/app/fragments/entry-item/entry-item.component.ts on lines 24..54
src/app/fragments/name-input-box/name-input-box.component.ts on lines 26..107
src/app/fragments/name-input/name-input.component.ts on lines 27..114
src/app/fragments/select-item/select-item.component.ts on lines 32..104
src/app/fragments/select-map-full/select-map-full.component.ts on lines 32..99
src/app/fragments/select-map/select-map.component.ts on lines 33..94
src/app/fragments/select-missable/select-missable.component.ts on lines 31..61
src/app/fragments/select-moves/select-moves.component.ts on lines 34..151
src/app/fragments/select-player-direction/select-player-directionr.component.ts on lines 24..39
src/app/fragments/select-species/select-species.component.ts on lines 32..91
src/app/fragments/select-sprite/select-sprite.component.ts on lines 29..59
src/app/fragments/select-starter/select-starter.component.ts on lines 24..37
src/app/fragments/select-status/select-status.component.ts on lines 24..40
src/app/fragments/select-trainer/select-trainer.component.ts on lines 31..61
src/app/fragments/select-type/select-type.component.ts on lines 25..51
src/app/fragments/sign-item/sign-item.component.ts on lines 24..54
src/app/fragments/warp-item/warp-item.component.ts on lines 24..54
src/app/fragments/wild-pokemon-item/wild-pokemon-item.component.ts on lines 24..95

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        const b = (val: number | any) => {
            return val.toString(16).padStart(2, "0").toUpperCase();
        }
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts and 2 other locations - About 35 mins to fix
src/app/fragments/select-map-full/select-map-full.component.ts on lines 64..66
src/app/fragments/select-map-full/select-map-full.component.ts on lines 68..70

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        let mapListGlitch: Map[] = _.filter(_maps, (value: Map) => {
            if (value.glitch && !value.special)
                return true;
 
            return false;
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts and 1 other location - About 35 mins to fix
src/app/fragments/select-item/select-item.component.ts on lines 73..78

Missing semicolon
Open

        }
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

if statements must be braced
Open

            if (el.special === true)
                return;
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

" should be '
Open

    public label: string = "Select Map";
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

Type string trivially inferred from a string literal, remove type annotation
Open

    public label: string = "Select Map";
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

" should be '
Open

const _: any = window.require("lodash");
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

" should be '
Open

            { name: "--- Normal Maps ---", ind: 0x100, disable: true },
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

Declaration of instance method not allowed after declaration of instance field. Instead, this should come at the beginning of the class/interface.
Open

    trackByFn(index: number) {
        return index;
    }
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

Type boolean trivially inferred from a boolean literal, remove type annotation
Open

    public disabled: boolean = false;
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

Missing semicolon
Open

}
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

if statements must be braced
Open

            if (!value.glitch && !value.special)
                return true;
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

Identifier '_maps' is never reassigned; use 'const' instead of 'let'.
Open

        let _maps: {
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

" should be '
Open

            { name: "--- Glitch Maps ---", ind: 0x100, disable: true },
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

" should be '
Open

            return val.toString().padStart(2, "0");
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

" should be '
Open

        const maps: Map[] = this.gd.file("maps").data;
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

Missing semicolon
Open

        }
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

if statements must be braced
Open

            if (value.glitch && !value.special)
                return true;
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

Type boolean trivially inferred from a boolean literal, remove type annotation
Open

    public noneSelectable: boolean = false;
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint

" should be '
Open

            return val.toString(16).padStart(2, "0").toUpperCase();
Severity: Minor
Found in src/app/fragments/select-map-width/select-map-width.component.ts by tslint
Category
Status