Sign upLogin

junebug12851/pokered-save-editor

View on GitHub
Star
src/app/fragments/select-sprite/select-sprite.component.ts

Summary

Maintainability
A
40 mins
Test Coverage

Showing 9 of 9 total issues

Similar blocks of code found in 20 locations. Consider refactoring.
Open

@Component({
    selector: 'select-sprite',
    templateUrl: './select-sprite.component.pug',
    styleUrls: ['./select-sprite.component.scss'],
    providers: [
Severity: Major
Found in src/app/fragments/select-sprite/select-sprite.component.ts and 19 other locations - About 40 mins to fix
src/app/fragments/connection-item/connection-item.component.ts on lines 25..48
src/app/fragments/entry-item/entry-item.component.ts on lines 24..54
src/app/fragments/name-input-box/name-input-box.component.ts on lines 26..107
src/app/fragments/name-input/name-input.component.ts on lines 27..114
src/app/fragments/select-item/select-item.component.ts on lines 32..104
src/app/fragments/select-map-full/select-map-full.component.ts on lines 32..99
src/app/fragments/select-map-width/select-map-width.component.ts on lines 32..121
src/app/fragments/select-map/select-map.component.ts on lines 33..94
src/app/fragments/select-missable/select-missable.component.ts on lines 31..61
src/app/fragments/select-moves/select-moves.component.ts on lines 34..151
src/app/fragments/select-player-direction/select-player-directionr.component.ts on lines 24..39
src/app/fragments/select-species/select-species.component.ts on lines 32..91
src/app/fragments/select-starter/select-starter.component.ts on lines 24..37
src/app/fragments/select-status/select-status.component.ts on lines 24..40
src/app/fragments/select-trainer/select-trainer.component.ts on lines 31..61
src/app/fragments/select-type/select-type.component.ts on lines 25..51
src/app/fragments/sign-item/sign-item.component.ts on lines 24..54
src/app/fragments/warp-item/warp-item.component.ts on lines 24..54
src/app/fragments/wild-pokemon-item/wild-pokemon-item.component.ts on lines 24..95

comment must start with a space
Open

//@ts-ignore
Severity: Minor
Found in src/app/fragments/select-sprite/select-sprite.component.ts by tslint

Type boolean trivially inferred from a boolean literal, remove type annotation
Open

    public disabled: boolean = false;
Severity: Minor
Found in src/app/fragments/select-sprite/select-sprite.component.ts by tslint

" should be '
Open

        const sprites: Sprite[] = _.sortBy(this.gd.file("sprites").data, ["ind"]);
Severity: Minor
Found in src/app/fragments/select-sprite/select-sprite.component.ts by tslint

" should be '
Open

const _ = window.require("lodash");
Severity: Minor
Found in src/app/fragments/select-sprite/select-sprite.component.ts by tslint

Declaration of instance method not allowed after declaration of instance field. Instead, this should come at the beginning of the class/interface.
Open

    spriteListTrackBy(index: number) {
        return index;
    }
Severity: Minor
Found in src/app/fragments/select-sprite/select-sprite.component.ts by tslint

" should be '
Open

        const sprites: Sprite[] = _.sortBy(this.gd.file("sprites").data, ["ind"]);
Severity: Minor
Found in src/app/fragments/select-sprite/select-sprite.component.ts by tslint

Type string trivially inferred from a string literal, remove type annotation
Open

    public label: string = "Sprite";
Severity: Minor
Found in src/app/fragments/select-sprite/select-sprite.component.ts by tslint

" should be '
Open

    public label: string = "Sprite";
Severity: Minor
Found in src/app/fragments/select-sprite/select-sprite.component.ts by tslint
Category
Status