Sign upLogin

juniorb2ss/zServices

View on GitHub
Star

Showing 19 of 19 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function scraping()
    {
        $scrapped = [];

        $this->hasError();
Severity: Major
Found in src/ReceitaFederal/Services/Portais/AN/Crawler.php and 1 other location - About 3 hrs to fix
src/Sintegra/Services/Portais/SP/Crawler.php on lines 52..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function scraping()
    {
        $scrapped = [];

        $this->hasError();
Severity: Major
Found in src/Sintegra/Services/Portais/SP/Crawler.php and 1 other location - About 3 hrs to fix
src/ReceitaFederal/Services/Portais/AN/Crawler.php on lines 64..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $curl->options([
            CURLOPT_COOKIEJAR => 'cookiejar',
            CURLOPT_HTTPHEADER => array(
                "Pragma: no-cache",
                "Origin: " . $this->configurations['base'],
Severity: Major
Found in src/Sintegra/Services/Portais/SP/Search.php and 1 other location - About 3 hrs to fix
src/ReceitaFederal/Services/Portais/AN/Search.php on lines 117..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $curl->options([
            CURLOPT_COOKIEJAR => 'cookiejar',
            CURLOPT_HTTPHEADER => array(
                "Pragma: no-cache",
                "Origin: " . $this->configurations['base'],
Severity: Major
Found in src/ReceitaFederal/Services/Portais/AN/Search.php and 1 other location - About 3 hrs to fix
src/Sintegra/Services/Portais/SP/Search.php on lines 136..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function scraping has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function scraping()
    {
        $scrapped = [];

        $this->hasError();
Severity: Minor
Found in src/Sintegra/Services/Portais/SP/Crawler.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function scraping has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function scraping()
    {
        $scrapped = [];

        $this->hasError();
Severity: Minor
Found in src/ReceitaFederal/Services/Portais/AN/Crawler.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getCaptcha has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getCaptcha() {
        $this->hasRequested();

        $imageSrc = $this->instanceResponse->filter(
            array_get($this->configurations, 'selectors.image')
Severity: Minor
Found in src/Sintegra/Services/Portais/SP/Search.php - About 1 hr to fix

Method getData has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getData($document, $cookie, $captcha, $params, $configurations) {

        // resolve captcha
        $captcha = $this->resolveCaptcha($captcha);
Severity: Minor
Found in src/ReceitaFederal/Services/Portais/AN/Search.php - About 1 hr to fix

Method getData has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getData($document, $cookie, $captcha, $params, $configurations) {

        // resolve captcha
        $captcha = $this->resolveCaptcha($captcha);
Severity: Minor
Found in src/Sintegra/Services/Portais/SP/Search.php - About 1 hr to fix

Method getCaptcha has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getCaptcha() {
        $this->hasRequested();

        // Inicia instancia do cURL
        $curl = new Curl;
Severity: Minor
Found in src/ReceitaFederal/Services/Portais/AN/Search.php - About 1 hr to fix

Method request has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function request($method, $url, array $parameters = array(), array $files = array(), array $server = array(), $content = null, $changeHistory = true)
Severity: Major
Found in src/Miscellany/ClientHttp.php - About 50 mins to fix

Method getData has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function getData($document, $cookie, $captcha, $params, $configurations);
Severity: Minor
Found in src/Miscellany/Interfaces/SearchInterface.php - About 35 mins to fix

Method sintegra has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    function sintegra($portal = 'SP', $document = false, $cookie = false, $captcha = false, $params = [])
Severity: Minor
Found in src/Helpers/Sintegra.php - About 35 mins to fix

Method getData has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function getData($document, $cookie, $captcha, $params, $configurations) {
Severity: Minor
Found in src/ReceitaFederal/Services/Portais/AN/Search.php - About 35 mins to fix

Method getData has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function getData($document, $cookie, $captcha, $params, $configurations) {
Severity: Minor
Found in src/Sintegra/Services/Portais/SP/Search.php - About 35 mins to fix

Remove error control operator '@' on line 147.
Open

    public function getCaptcha() {
        $this->hasRequested();

        // Inicia instancia do cURL
        $curl = new Curl;
Severity: Minor
Found in src/ReceitaFederal/Services/Portais/AN/Search.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 166.
Open

    public function getCaptcha() {
        $this->hasRequested();

        $imageSrc = $this->instanceResponse->filter(
            array_get($this->configurations, 'selectors.image')
Severity: Minor
Found in src/Sintegra/Services/Portais/SP/Search.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '19', column '18').
Open

        $search = (new \zServices\Sintegra\Search)->service($portal);
Severity: Minor
Found in src/Helpers/Sintegra.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '17', column '18').
Open

        $search = (new \zServices\ReceitaFederal\Search)->service();
Severity: Minor
Found in src/Helpers/ReceitaFederal.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Severity
Category
Status
Source
Language