Sign upLogin

jxlwqq/id-validator

View on GitHub
Star

Showing 7 of 7 total issues

File addressCode.php has 3212 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php


/**
 * 行政区划代码（地址码）
Severity: Major
Found in data/addressCode.php - About 1 wk to fix

    File additionalAddressCodeTimeline.php has 3170 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php


/**
 * 行政区划代码（地址码）
    Severity: Major
    Found in data/additionalAddressCodeTimeline.php - About 1 wk to fix

      Function _getAddress has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          private function _getAddress($addressCode, $birthdayCode, $strictMode = false)
    {
        $address = '';
        if (isset($this->_addressCodeTimeline[$addressCode])) {
            $timeline = $this->_addressCodeTimeline[$addressCode];
      Severity: Minor
      Found in src/Helper.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _generatorBirthdayCode has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          private function _generatorBirthdayCode($addressCode, $address, $birthday)
    {
        $start_year = '0001';
        $end_year = '9999';
        $year = $this->_datePad(substr($birthday, 0, 4), 'year');
      Severity: Minor
      Found in src/Generator.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _generatorBirthdayCode has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function _generatorBirthdayCode($addressCode, $address, $birthday)
    {
        $start_year = '0001';
        $end_year = '9999';
        $year = $this->_datePad(substr($birthday, 0, 4), 'year');
      Severity: Minor
      Found in src/Generator.php - About 1 hr to fix

        Method _getAddress has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function _getAddress($addressCode, $birthdayCode, $strictMode = false)
    {
        $address = '';
        if (isset($this->_addressCodeTimeline[$addressCode])) {
            $timeline = $this->_addressCodeTimeline[$addressCode];
        Severity: Minor
        Found in src/Helper.php - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                  return 'district';
          Severity: Major
          Found in src/Generator.php - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language