k911/swoole-bundle

View on GitHub
src/Bridge/Symfony/HttpFoundation/Session/SwooleSessionStorage.php

Summary

Maintainability
A
0 mins
Test Coverage
B
87%

Missing class import via use statement (line '219', column '23').
Open

            throw new \LogicException('Cannot register a bag when the session is already started.');

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method regenerate has a boolean flag argument $destroy, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function regenerate($destroy = false, $lifetime = null): bool

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '203', column '23').
Open

            throw new \InvalidArgumentException(\sprintf('The SessionBagInterface `%s` is not registered.', $name));

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

There are no issues that match your filters.

Category
Status