Sign upLogin

kabisa/kudos-frontend

View on GitHub
Star
src/modules/manage-team/sections/guideline/EditGuideline.tsx

Summary

Maintainability
C
1 day
Test Coverage
A
91%

Function render has 103 lines of code (exceeds 80 allowed). Consider refactoring.
Open

  render() {
    return (
      <Mutation<CreateGuidelineParameters>
        mutation={this.state.editing ? UPDATE_GUIDELINE : CREATE_GUIDELINE}
        onCompleted={() => {
Severity: Major
Found in src/modules/manage-team/sections/guideline/EditGuideline.tsx - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                      onChange={(e) => {
                    this.state.editing
                      ? this.setState({ editKudos: e.target.value })
                      : this.setState({ kudos: e.target.value });
                  }}
    Severity: Major
    Found in src/modules/manage-team/sections/guideline/EditGuideline.tsx and 1 other location - About 1 hr to fix
    src/modules/manage-team/sections/guideline/EditGuideline.tsx on lines 156..160

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                      onChange={(e) => {
                    this.state.editing
                      ? this.setState({ editDescription: e.target.value })
                      : this.setState({ description: e.target.value });
                  }}
    Severity: Major
    Found in src/modules/manage-team/sections/guideline/EditGuideline.tsx and 1 other location - About 1 hr to fix
    src/modules/manage-team/sections/guideline/EditGuideline.tsx on lines 136..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                <form
              onSubmit={(e) => {
                e.preventDefault();

                this.state.editing
    Severity: Major
    Found in src/modules/manage-team/sections/guideline/EditGuideline.tsx and 1 other location - About 1 hr to fix
    src/modules/manage-team/sections/kudometer/goals/EditGoal.tsx on lines 124..198

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                  <Button
                data-testid="submit-button"
                variant="primary"
                disabled={loading}
                type="submit"
    Severity: Minor
    Found in src/modules/manage-team/sections/guideline/EditGuideline.tsx and 1 other location - About 50 mins to fix
    src/modules/manage-team/sections/kudometer/goals/EditGoal.tsx on lines 174..181

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    An empty interface is equivalent to {}.
    Open

    export interface EditGuidelineProps {}
    Severity: Minor
    Found in src/modules/manage-team/sections/guideline/EditGuideline.tsx by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Missing return type on function.
    Open

      updateGuideline(mutate: any) {
    Severity: Minor
    Found in src/modules/manage-team/sections/guideline/EditGuideline.tsx by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Missing return type on function.
    Open

      createGuideline(mutate: any) {
    Severity: Minor
    Found in src/modules/manage-team/sections/guideline/EditGuideline.tsx by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Argument 'mutate' should be typed with a non-any type.
    Open

      createGuideline(mutate: any) {
    Severity: Minor
    Found in src/modules/manage-team/sections/guideline/EditGuideline.tsx by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Missing return type on function.
    Open

      render() {
    Severity: Minor
    Found in src/modules/manage-team/sections/guideline/EditGuideline.tsx by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Argument 'mutate' should be typed with a non-any type.
    Open

      updateGuideline(mutate: any) {
    Severity: Minor
    Found in src/modules/manage-team/sections/guideline/EditGuideline.tsx by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Missing return type on function.
    Open

      setEditState(id: number, kudos: string, description: string) {
    Severity: Minor
    Found in src/modules/manage-team/sections/guideline/EditGuideline.tsx by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status