Showing 2 of 2 total issues
Function __converter
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def __converter(self, letter):
letter = letter.decode('utf-8') if version_info[0] == 2 else letter
if letter.upper() in self.phonetic_dict['alphabet'].keys():
phonetic_code = self.phonetic_dict['alphabet'][letter.upper()]
if letter.isupper():
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Multiple spaces before keyword Open
Open
sign=args.sign if not args.nosign else '',
- Read upRead up
- Exclude checks
Avoid extraneous whitespace around keywords.
Okay: True and False
E271: True and False
E272: True and False
E273: True and\tFalse
E274: True\tand False