Sign upLogin

kacotam-si/portal-core

View on GitHub
Star
portal_core/mixins.py

Summary

Maintainability
A
1 hr
Test Coverage

Function render_to_csv has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def render_to_csv(self, data, fieldnames=None, with_bom=True,
                      fail_silent=True):
        response = HttpResponse(content_type=self.content_type)
        response['Content-Disposition'] = self.get_context_disposition()
        if with_bom:
Severity: Minor
Found in portal_core/mixins.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Do not use bare 'except'
Open

            except:
Severity: Minor
Found in portal_core/mixins.py by pep8

When catching exceptions, mention specific exceptions when possible.

Okay: except Exception:
Okay: except BaseException:
E722: except:

There are no issues that match your filters.

Category
Status