kai-jacobsen/kontentblocks

View on GitHub

Showing 4,293 of 4,293 total issues

Function _decodeFeatures has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      _decodeFeatures: function(data) {
        var results = [],
          i,
          f,
          c,
Severity: Minor
Found in js/third-party/leaflet-geocoder.js - About 1 hr to fix

    Function reverse has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        reverse: function(location, scale, cb, context) {
          getJSON(
            this.options.serviceUrl + 'reverse',
            L.extend(
              {
    Severity: Minor
    Found in js/third-party/leaflet.js - About 1 hr to fix

      Function geocode has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          geocode: function(query, cb, context) {
            getJSON(
              this.options.serviceUrl + 'search',
              L.extend(
                {
      Severity: Minor
      Found in js/third-party/leaflet.js - About 1 hr to fix

        Method renderSingleArea has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function renderSingleArea($areaId, $post_id = null, $areaSettings = array(), $moduleSettings = array(), $echo = true)
        {
            global $post;
            $postId = (is_null($post_id) && !is_null($post)) ? $post->ID : $post_id;
        
        
        Severity: Minor
        Found in includes/kb-api.php - About 1 hr to fix

          Method init has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function init()
              {
                  $areas = wp_cache_get('dynamicareas', Utilities::getCacheGroup());
          
                  if ($areas === false) {
          Severity: Minor
          Found in core/Areas/AreaRegistry.php - About 1 hr to fix

            Method settingsForm has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function settingsForm($data)
                {
                    $templateData = array(
                        'strings' => I18n::getPackages('Areas', 'Common'),
                        'editMode' => (!empty($data)),
            Severity: Minor
            Found in core/Backend/Dynamic/DynamicAreas.php - About 1 hr to fix

              Method addByFile has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function addByFile($file)
                  {
                      include_once $file;
                      $classname = str_replace('.php', '', basename($file));
                      $modelArg = '';
              Severity: Minor
              Found in core/Panels/PanelRegistry.php - About 1 hr to fix

                Method action has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected static function action(Request $request)
                    {
                        if (!defined('KB_ONSITE_ACTIVE')) {
                            define('KB_ONSITE_ACTIVE', true);
                        }
                Severity: Minor
                Found in core/Ajax/Actions/Frontend/GetModuleForm.php - About 1 hr to fix

                  Method toJSON has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function toJSON()
                      {
                          $json = array(
                              'width' => $this->image->size[0],
                              'height' => $this->image->size[1],
                  Severity: Minor
                  Found in core/Fields/Definitions/ReturnObjects/EditableImage.php - About 1 hr to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                      getIdsFromInputs: function () {
                        return this.$('.kb-gallery--image-holder input').map(function (idx, ele) {
                          return jQuery(ele).val();
                        }).get();
                      },
                    Severity: Major
                    Found in js/src/fields/controls/gallery2/Gallery2Controller.js and 1 other location - About 1 hr to fix
                    js/src/fields/controls/gallery-ext/GalleryExtController.js on lines 178..182

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 57.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                      getIdsFromInputs: function () {
                        return this.$('.kb-gallery--image-holder input').map(function (idx, ele) {
                          return jQuery(ele).val();
                        }).get();
                      },
                    Severity: Major
                    Found in js/src/fields/controls/gallery-ext/GalleryExtController.js and 1 other location - About 1 hr to fix
                    js/src/fields/controls/gallery2/Gallery2Controller.js on lines 164..168

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 57.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function render has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                      render: function (reload) {
                        var that = this,
                          json;
                        Logger.User.info('Frontend modal retrieves data from the server');
                        json = this.model.toJSON();
                    Severity: Minor
                    Found in js/src/frontend/Views/EditModalModules.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function moduleUpdated has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                      moduleUpdated: function (res, b, c, save, notice) {
                        var that = this;
                    
                        that.model.trigger('modal.serialize.before');
                    
                    
                    Severity: Minor
                    Found in js/src/frontend/Views/EditModalModules.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function App has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                    KB.App = function () {
                    
                      /*
                       Frontend bootstrap
                       called on jquery.ready
                    Severity: Minor
                    Found in js/src/frontend/FrontendController.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function postRender has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                      postRender: function () {
                        var value = this.model.get('value');
                        var queryargs = {};
                        var that = this;
                        var id = this.model.get('value').id;
                    Severity: Minor
                    Found in js/src/fieldsAPI/definitions/image.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function renderAreas has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function renderAreas()
                        {
                            $out = '';
                            foreach ($this->areas as $area) {
                    
                    
                    Severity: Minor
                    Found in core/Backend/EditScreens/ScreenContext.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function prepareFromModule has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function prepareFromModule()
                        {
                            /** @var \Kontentblocks\Modules\Module $fModule */
                            $fModule = new $this->moduleattrs['class']( $this->getPropertiesObject(), null, $this->environment );
                            if (!$fModule->fields && !method_exists( $this->module, 'defaultData' )) {
                    Severity: Minor
                    Found in core/Modules/ModuleWorkshop.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function render has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function render($echo = false)
                        {
                            $concater = ConcatContent::getInstance();
                    
                            if (!is_null($this->path)) {
                    Severity: Minor
                    Found in core/Utils/CommonTwig/SimpleView.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function createOrGetFieldDataArray has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function createOrGetFieldDataArray($modid, $type, $key, $arrayKey = null)
                        {
                    
                    
                            if (!isset($this->fieldData[$type])) {
                    Severity: Minor
                    Found in core/Utils/JSONTransport.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function save has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function save($new, $old)
                        {
                            $new = array_values($new);
                            if (is_array($new) && is_array($old)) {
                                $nc = count($new);
                    Severity: Minor
                    Found in core/Fields/Definitions/DateMultiple.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language