Showing 4,293 of 4,293 total issues
Function _decodeFeatures
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
_decodeFeatures: function(data) {
var results = [],
i,
f,
c,
Function reverse
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
reverse: function(location, scale, cb, context) {
getJSON(
this.options.serviceUrl + 'reverse',
L.extend(
{
Function geocode
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
geocode: function(query, cb, context) {
getJSON(
this.options.serviceUrl + 'search',
L.extend(
{
Method renderSingleArea
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
function renderSingleArea($areaId, $post_id = null, $areaSettings = array(), $moduleSettings = array(), $echo = true)
{
global $post;
$postId = (is_null($post_id) && !is_null($post)) ? $post->ID : $post_id;
Method init
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function init()
{
$areas = wp_cache_get('dynamicareas', Utilities::getCacheGroup());
if ($areas === false) {
Method settingsForm
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function settingsForm($data)
{
$templateData = array(
'strings' => I18n::getPackages('Areas', 'Common'),
'editMode' => (!empty($data)),
Method addByFile
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function addByFile($file)
{
include_once $file;
$classname = str_replace('.php', '', basename($file));
$modelArg = '';
Method action
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected static function action(Request $request)
{
if (!defined('KB_ONSITE_ACTIVE')) {
define('KB_ONSITE_ACTIVE', true);
}
Method toJSON
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function toJSON()
{
$json = array(
'width' => $this->image->size[0],
'height' => $this->image->size[1],
Identical blocks of code found in 2 locations. Consider refactoring. Open
getIdsFromInputs: function () {
return this.$('.kb-gallery--image-holder input').map(function (idx, ele) {
return jQuery(ele).val();
}).get();
},
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 57.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
getIdsFromInputs: function () {
return this.$('.kb-gallery--image-holder input').map(function (idx, ele) {
return jQuery(ele).val();
}).get();
},
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 57.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function render
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
render: function (reload) {
var that = this,
json;
Logger.User.info('Frontend modal retrieves data from the server');
json = this.model.toJSON();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function moduleUpdated
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
moduleUpdated: function (res, b, c, save, notice) {
var that = this;
that.model.trigger('modal.serialize.before');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function App
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
KB.App = function () {
/*
Frontend bootstrap
called on jquery.ready
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function postRender
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
postRender: function () {
var value = this.model.get('value');
var queryargs = {};
var that = this;
var id = this.model.get('value').id;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function renderAreas
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function renderAreas()
{
$out = '';
foreach ($this->areas as $area) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function prepareFromModule
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private function prepareFromModule()
{
/** @var \Kontentblocks\Modules\Module $fModule */
$fModule = new $this->moduleattrs['class']( $this->getPropertiesObject(), null, $this->environment );
if (!$fModule->fields && !method_exists( $this->module, 'defaultData' )) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function render
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function render($echo = false)
{
$concater = ConcatContent::getInstance();
if (!is_null($this->path)) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function createOrGetFieldDataArray
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private function createOrGetFieldDataArray($modid, $type, $key, $arrayKey = null)
{
if (!isset($this->fieldData[$type])) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function save
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function save($new, $old)
{
$new = array_values($new);
if (is_array($new) && is_array($old)) {
$nc = count($new);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"