Sign upLogin

kai-jacobsen/kontentblocks

View on GitHub
Star

Showing 4,293 of 4,293 total issues

Avoid using static access to class '\Kontentblocks\Utils\Utilities' in method 'createBackup'.
Open

        if (Utilities::isPreview()) {
Severity: Minor
Found in core/Backend/Environment/Save/SavePost.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method saveModules uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $savedData = Utilities::arrayMergeRecursive($new, $old);
                }
Severity: Minor
Found in core/Backend/Environment/Save/SaveRevision.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Kontentblocks\Utils\Utilities' in method 'insertBackup'.
Open

        wp_cache_delete('kb_backups_' . $data['post_id'], Utilities::getCacheGroup());
Severity: Minor
Found in core/Backend/Storage/BackupDataStorage2.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Kontentblocks\Utils\Utilities' in method 'loadFile'.
Open

            $cached = wp_cache_get($cachekey, Utilities::getCacheGroup());
Severity: Minor
Found in core/Common/Data/YAMLLoader.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$direction'.
Open

    private function getValueForFieldOfPanel($panelId, $field, $post, $direction)
Severity: Minor
Found in core/Backend/EditScreens/Revisions.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$taxonomy'.
Open

    public function preparePanels($term, $taxonomy)
Severity: Minor
Found in core/Backend/EditScreens/TaxonomyEditScreen.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Kontentblocks\Utils\Utilities' in method 'preparePanels'.
Open

        return Utilities::getUserEnvironment($userObj->ID, $userObj);
Severity: Minor
Found in core/Backend/EditScreens/UserEditScreen.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Kontentblocks\Utils\Utilities' in method 'deleteEntry'.
Open

        wp_cache_delete('kb_backups_' . $this->environment->getId(), Utilities::getCacheGroup());
Severity: Minor
Found in core/Backend/Storage/BackupDataStorage2.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method compare uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {

            if ($group['start']['short'] === $group['end']['short']) {
                $group['shortstring'] = $group['start']['short'];
                $group['longstring'] = $group['start']['long'];
Severity: Minor
Found in core/Fields/Definitions/ReturnObjects/OpeningTimesReturn.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return $new;
        }
Severity: Minor
Found in core/Fields/Field.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $out .= $this->body();
        }
Severity: Minor
Found in core/Fields/FieldFormRenderer.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused private methods such as 'getFielddata'.
Open

    private function getFielddata(ExportableFieldInterface $field)
    {
        $data = $this->getEntityModel();
        if (isset($data[$field->getKey()])) {
            return (is_object($data) && !is_null(
Severity: Minor
Found in core/Fields/StandardFieldSection.php by phpmd

UnusedPrivateMethod

Since: 0.2

Unused Private Method detects when a private method is declared but is unused.

Example

class Something
{
    private function foo() {} // unused
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

Avoid using static access to class '\Kontentblocks\Utils\Utilities' in method 'setupProperties'.
Open

            'context' => Utilities::getTemplateFile(),
Severity: Minor
Found in core/Frontend/AreaRenderSettings.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Kontentblocks\Utils\Utilities' in method 'saveCallback'.
Open

        $postData = Utilities::getRequest();
Severity: Minor
Found in core/Panels/UserPanel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Kontentblocks\Templating\Twig' in method '__construct'.
Open

            Twig::setPath(dirname($tpl));
Severity: Minor
Found in core/Templating/CoreView.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused local variables such as '$check'.
Open

    $check = false;
Severity: Minor
Found in core/Extensions/OSAdminBar.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The method mapDays uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        $v['valid'] = false;
                    }
Severity: Minor
Found in core/Fields/Definitions/ReturnObjects/OpeningTimesReturn.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Kontentblocks\Kontentblocks' in method '__construct'.
Open

        $this->engine = Kontentblocks::getService( 'templating.twig.public' );
Severity: Minor
Found in core/Templating/AreaView.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method getArg uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return $default;
        }
Severity: Minor
Found in core/Fields/Field.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$old'.
Open

    public function save($new, $old)
Severity: Minor
Found in core/Fields/Field.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Severity
Category
Status
Source
Language