Sign upLogin

kalefranz/auxlib

View on GitHub
Star
auxlib/type_coercion.py

Summary

Maintainability
C
1 day
Test Coverage

Cyclomatic complexity is too high in function typify. (17)
Open

def typify(value, type_hint=None):
    """Take a primitive value, usually a string, and try to make a more relevant type out of it.
    An optional type_hint will try to coerce the value to that type.

    Args:
Severity: Minor
Found in auxlib/type_coercion.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function typify has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

def typify(value, type_hint=None):
    """Take a primitive value, usually a string, and try to make a more relevant type out of it.
    An optional type_hint will try to coerce the value to that type.

    Args:
Severity: Minor
Found in auxlib/type_coercion.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity is too high in function boolify. (10)
Open

def boolify(value, nullable=False, return_string=False):
    """Convert a number, string, or sequence type into a pure boolean.

    Args:
        value (number, string, sequence): pretty much anything
Severity: Minor
Found in auxlib/type_coercion.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function typify_data_structure. (8)
Open

def typify_data_structure(value, type_hint=None):
    if isinstance(value, Mapping):
        return type(value)((k, typify(v, type_hint)) for k, v in iteritems(value))
    elif isiterable(value):
        return type(value)(typify(v, type_hint) for v in value)
Severity: Minor
Found in auxlib/type_coercion.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function boolify has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def boolify(value, nullable=False, return_string=False):
    """Convert a number, string, or sequence type into a pure boolean.

    Args:
        value (number, string, sequence): pretty much anything
Severity: Minor
Found in auxlib/type_coercion.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return False
Severity: Major
Found in auxlib/type_coercion.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return bool(complex(val))
    Severity: Major
    Found in auxlib/type_coercion.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return boolify(value, nullable=True)
      Severity: Major
      Found in auxlib/type_coercion.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return typify_str_no_hint(value)
        Severity: Major
        Found in auxlib/type_coercion.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return None if value.lower() == 'none' else value
          Severity: Major
          Found in auxlib/type_coercion.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return typify_str_no_hint(text_type(value))
            Severity: Major
            Found in auxlib/type_coercion.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return value
              Severity: Major
              Found in auxlib/type_coercion.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return boolify(value, return_string=True)
                Severity: Major
                Found in auxlib/type_coercion.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return text_type(value)
                  Severity: Major
                  Found in auxlib/type_coercion.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return boolify(value) if type_hint == bool else type_hint(value)
                    Severity: Major
                    Found in auxlib/type_coercion.py - About 30 mins to fix

                      There are no issues that match your filters.

                      Category
                      Status