kalenjordan/magehero

View on GitHub
code/Model/User.php

Summary

Maintainability
D
2 days
Test Coverage

Model_User has 47 functions (exceeds 20 allowed). Consider refactoring.
Open

class Model_User extends Model_Record
{
    protected $_data;
    protected $_lastPost;

Severity: Minor
Found in code/Model/User.php - About 6 hrs to fix

    File User.php has 301 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    class Model_User extends Model_Record
    {
        protected $_data;
    Severity: Minor
    Found in code/Model/User.php - About 3 hrs to fix

      Method selectAll has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function selectAll()
          {
              $postsQuery = $this->_localConfig->database()->select()
                  ->from('posts', array(
                      'user_id',
      Severity: Minor
      Found in code/Model/User.php - About 1 hr to fix

        Method loadByUsername has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function loadByUsername($username)
            {
                $query = $this->_localConfig->database()->select()
                    ->from("users")
                    ->joinLeft(
        Severity: Minor
        Found in code/Model/User.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function search($term)
              {
                  $terms = explode(" ", $term);
          
                  $searchQuery = array();
          Severity: Major
          Found in code/Model/User.php and 1 other location - About 6 hrs to fix
          code/Model/Post.php on lines 216..245

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 220.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status