Showing 17 of 17 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
package editor
import "os"
func Micro() Editor {- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 113.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
package editor
import "os"
func Emacs() Editor {- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 113.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
exported function New should have comment or be unexported Open
func New() (config *Config, err error) {- Exclude checks
exported function Vim should have comment or be unexported Open
func Vim() Editor {- Exclude checks
exported type Attachment should have comment or be unexported Open
type Attachment struct {- Exclude checks
exported type Config should have comment or be unexported Open
type Config struct {- Exclude checks
exported type Editor should have comment or be unexported Open
type Editor interface {- Exclude checks
2: cannot find package "github.com/kamiazya/memomail/adapter/mailer" in any of: Open
"github.com/kamiazya/memomail/adapter/mailer"- Exclude checks
exported type Config should have comment or be unexported Open
type Config struct {- Exclude checks
exported function Micro should have comment or be unexported Open
func Micro() Editor {- Exclude checks
exported type Mailer should have comment or be unexported Open
type Mailer interface {- Exclude checks
exported method Config.SaveConfig should have comment or be unexported Open
func (c *Config) SaveConfig() {- Exclude checks
exported function New should have comment or be unexported Open
func New(c *Config) Mailer {- Exclude checks
exported type Message should have comment or be unexported Open
type Message []byte- Exclude checks
exported function Execute should have comment or be unexported Open
func Execute() {- Exclude checks
exported function ReadMessage should have comment or be unexported Open
func ReadMessage() (msg *message.Message, err error) {- Exclude checks
exported function Emacs should have comment or be unexported Open
func Emacs() Editor {- Exclude checks