Sign upLogin

kangoo13/laravel-minecraft-jsonapi-client

View on GitHub
Star
src/Services/MinecraftJsonApiClient.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '126', column '23').
Open

            throw new \Exception('Cannot decode response of minecraft server', 500);
Severity: Minor
Found in src/Services/MinecraftJsonApiClient.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '121', column '23').
Open

            throw new \Exception('Call failed to minecraft server', $response->getStatusCode());
Severity: Minor
Found in src/Services/MinecraftJsonApiClient.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\Doctrine\Common\Annotations\AnnotationRegistry' in method '__construct'.
Open

        AnnotationRegistry::registerLoader('class_exists');
Severity: Minor
Found in src/Services/MinecraftJsonApiClient.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid assigning values to variables in if clauses and the like (line '125', column '15').
Open

    protected function call(string $commandName, array $commandArguments = [])
    {
        try {
            $response = $this->client->request('GET', 'call', [
                'query' => [
Severity: Minor
Found in src/Services/MinecraftJsonApiClient.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Define and throw a dedicated exception instead of using a generic one.
Open

            throw new \Exception('Call failed to minecraft server', $response->getStatusCode());
Severity: Major
Found in src/Services/MinecraftJsonApiClient.php by sonar-php

If you throw a general exception type, such as ErrorException, RuntimeException, or Exception in a library or framework, it forces consumers to catch all exceptions, including unknown exceptions that they do not know how to handle.

Instead, either throw a subtype that already exists in the Standard PHP Library, or create your own type that derives from Exception.

Noncompliant Code Example

throw new Exception();  // Noncompliant

Compliant Solution

throw new InvalidArgumentException();
// or
throw new UnexpectedValueException();

See

Define and throw a dedicated exception instead of using a generic one.
Open

            throw new \Exception('Cannot decode response of minecraft server', 500);
Severity: Major
Found in src/Services/MinecraftJsonApiClient.php by sonar-php

If you throw a general exception type, such as ErrorException, RuntimeException, or Exception in a library or framework, it forces consumers to catch all exceptions, including unknown exceptions that they do not know how to handle.

Instead, either throw a subtype that already exists in the Standard PHP Library, or create your own type that derives from Exception.

Noncompliant Code Example

throw new Exception();  // Noncompliant

Compliant Solution

throw new InvalidArgumentException();
// or
throw new UnexpectedValueException();

See

Avoid variables with short names like $ip. Configured minimum length is 3.
Open

        string $ip = '127.0.0.1',
Severity: Minor
Found in src/Services/MinecraftJsonApiClient.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status