kapost/kapost_deploy

View on GitHub
lib/kapost_deploy/slack/notifier.rb

Summary

Maintainability
A
0 mins
Test Coverage

KapostDeploy::Slack::Notifier#configured? performs a nil-check
Open

        !slack_config.nil?
Severity: Minor
Found in lib/kapost_deploy/slack/notifier.rb by reek

A NilCheck is a type check. Failures of NilCheck violate the "tell, don't ask" principle.

Additionally, type checks often mask bigger problems in your source code like not using OOP and / or polymorphism when you should.

Example

Given

class Klass
  def nil_checker(argument)
    if argument.nil?
      puts "argument isn't nil!"
    end
  end
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [3]:Klass#nil_checker performs a nil-check. (NilCheck)

There are no issues that match your filters.

Category
Status