Sign upLogin

karafka/karafka

View on GitHub
Star
lib/karafka/pro/processing/strategies/ftr/default.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method handle_post_filtering has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            def handle_post_filtering
              filter = coordinator.filter

              # We pick the timeout before the action because every action takes time. This time
              # may then mean we end up having throttle time equal to zero when pause is needed
Severity: Minor
Found in lib/karafka/pro/processing/strategies/ftr/default.rb - About 1 hr to fix

    Method handle_after_consume has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

                def handle_after_consume
              coordinator.on_finished do |last_group_message|
                return if revoked?

                if coordinator.success?
    Severity: Minor
    Found in lib/karafka/pro/processing/strategies/ftr/default.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status