Sign upLogin

karafka/karafka

View on GitHub
Star
lib/karafka/swarm/supervisor.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method stop has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def stop
        # Ensure that the stopping procedure is initialized only once
        @mutex.synchronize do
          return if @stopping
Severity: Minor
Found in lib/karafka/swarm/supervisor.rb - About 1 hr to fix

    Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def run
        # Close producer just in case. While it should not be used, we do not want even a
        # theoretical case since librdkafka is not thread-safe.
        # We close it prior to forking just to make sure, there is no issue with initialized
        # producer (should not be initialized but just in case)
    Severity: Minor
    Found in lib/karafka/swarm/supervisor.rb - About 1 hr to fix

      Method stop has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

            def stop
        # Ensure that the stopping procedure is initialized only once
        @mutex.synchronize do
          return if @stopping
      Severity: Minor
      Found in lib/karafka/swarm/supervisor.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status