Sign upLogin

kariminf/aruudy

View on GitHub
Star
aruudy/db/litebase.py

Summary

Maintainability
D
2 days
Test Coverage

File litebase.py has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# -*- coding: utf-8 -*-
#
#  litebase.py
#  Used to manage Sqlite database with easiest way
Severity: Minor
Found in aruudy/db/litebase.py - About 2 hrs to fix

    Function makeLiteType has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def makeLiteType(stringType):
    stringType = string.upper(stringType)
    if re.match('INT[^\(]', stringType):
        return liteINT(0)
    if re.match('TEXT', stringType):
    Severity: Minor
    Found in aruudy/db/litebase.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setPath has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def setPath(self, filePath):
        if self.__database:
            print 'Database already exists'
            return
    Severity: Minor
    Found in aruudy/db/litebase.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

            return liteINT(num)
    Severity: Major
    Found in aruudy/db/litebase.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return liteVARCHAR(num)
      Severity: Major
      Found in aruudy/db/litebase.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return liteType(stringType)
        Severity: Major
        Found in aruudy/db/litebase.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return liteCHAR(num)
          Severity: Major
          Found in aruudy/db/litebase.py - About 30 mins to fix

            Function addColumn has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def addColumn(self, columnName, columnDef, columnInf, index):
        if not self.__canAddColumns:
            return 
        if len(self.__tableName) < 1:
            return
            Severity: Minor
            Found in aruudy/db/litebase.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function __addTable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def __addTable(self, sqlQuery):

        sqlQuery = u'' + sqlQuery    
        theLiteTable = liteTable()
        tableName = u''
            Severity: Minor
            Found in aruudy/db/litebase.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    for m in matches:
            if "CREATE" in m:
                continue
            if "KEY" in m:
                continue
            Severity: Major
            Found in aruudy/db/litebase.py and 1 other location - About 4 hrs to fix
            aruudy/db/litebase.py on lines 80..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 77.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    for m in matches:
            if "CREATE" in m:
                continue
            if "KEY" in m:
                continue
            Severity: Major
            Found in aruudy/db/litebase.py and 1 other location - About 4 hrs to fix
            aruudy/db/litebase.py on lines 270..278

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 77.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            class liteCHAR(liteType):
    def __init__(self, number):
        if number < 1:
            number = 1
        definition = u'CHAR(%s)' % number
            Severity: Major
            Found in aruudy/db/litebase.py and 1 other location - About 1 hr to fix
            aruudy/db/litebase.py on lines 306..311

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            class liteVARCHAR(liteType):
    def __init__(self, number):
        if number < 1:
            number = 1
        definition = u'VARCHAR(%s)' % number
            Severity: Major
            Found in aruudy/db/litebase.py and 1 other location - About 1 hr to fix
            aruudy/db/litebase.py on lines 299..304

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status