Sign upLogin

karlfreeman/multi_sync

View on GitHub
Star

Showing 10 of 10 total issues

Method determine_sync has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def determine_sync
      sources.each do |source|

        source_files = []
Severity: Minor
Found in lib/multi_sync/client.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method determine_sync has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def determine_sync
      sources.each do |source|

        source_files = []
Severity: Minor
Found in lib/multi_sync/client.rb - About 1 hr to fix

    Method pluralize has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def pluralize(n, singular, plural = nil, prefix = true)
        if n == 1
          (prefix ? '1 ' : '') + singular
        elsif plural
          (prefix ? "#{n} " : '') + plural
    Severity: Minor
    Found in lib/multi_sync/helpers/pluralize.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method sync has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def sync
      MultiSync.warn 'Preventing synchronization as there are no sources found.' && return if sync_pointless?

      if first_run?
        MultiSync.debug 'Starting synchronization...'
    Severity: Minor
    Found in lib/multi_sync/client.rb - About 1 hr to fix

      Method parse_manifest has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def parse_manifest(manifest_path)
      manifest_hash = {}
      manifest_data = File.read(manifest_path)

      # manifest files can be YAML or JSON but Sprockets::Manifest isn't backwards compatible with that in mind :(
      Severity: Minor
      Found in lib/multi_sync/sources/manifest_source.rb - About 1 hr to fix

        Method sync has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def sync
      MultiSync.warn 'Preventing synchronization as there are no sources found.' && return if sync_pointless?

      if first_run?
        MultiSync.debug 'Starting synchronization...'
        Severity: Minor
        Found in lib/multi_sync/client.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method files has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def files
      files = []

      directory = connection.directories.get(target_dir.to_s, prefix: destination_dir.to_s)
      return files if directory.nil?
        Severity: Minor
        Found in lib/multi_sync/targets/aws_target.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method finish_sync has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def finish_sync
      # recurse when there are incomplete_jobs still
      incomplete_jobs.length != 0 ? sync : self.finished_at = Time.now

      if finished_at
        Severity: Minor
        Found in lib/multi_sync/client.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              (running_delete_jobs | incomplete_delete_jobs).each do | job |
        begin
          complete_delete_jobs << job.value
        rescue => error
          self.file_sync_attempts = file_sync_attempts + 1
        Severity: Minor
        Found in lib/multi_sync/client.rb and 1 other location - About 20 mins to fix
        lib/multi_sync/client.rb on lines 71..78

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              (running_upload_jobs | incomplete_upload_jobs).each do | job |
        begin
          complete_upload_jobs << job.value
        rescue => error
          self.file_sync_attempts = file_sync_attempts + 1
        Severity: Minor
        Found in lib/multi_sync/client.rb and 1 other location - About 20 mins to fix
        lib/multi_sync/client.rb on lines 82..89

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language