Sign upLogin

kaspernj/apsis-on-steroids

View on GitHub
Star

Showing 17 of 17 total issues

Method subscribers has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def subscribers(args = {}, &blk)
    args.each do |key, value|
      raise "Invalid argument: '#{key}'." unless SUBSCRIBERS_VALID_ARGS.include?(key)
    end
Severity: Minor
Found in include/mailing_list.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method subscribers has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def subscribers(args = {}, &blk)
    args.each do |key, value|
      raise "Invalid argument: '#{key}'." unless SUBSCRIBERS_VALID_ARGS.include?(key)
    end
Severity: Major
Found in include/mailing_list.rb - About 2 hrs to fix

    Method update has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      def update(data)
    begin
      res = aos.req_json("v1/subscribers/queue", :post, json: [data.merge(:Id => self.data(:id))])
      url = URI.parse(res["Result"]["PollURL"])
      result = nil
    Severity: Minor
    Found in include/subscriber.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        Timeout.timeout(300) do
      loop do
        sleep 1

        data = aos.req(url.path)
    Severity: Major
    Found in include/mailing_list.rb and 1 other location - About 1 hr to fix
    include/mailing_list.rb on lines 241..258

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        Timeout.timeout(300) do
      loop do
        sleep 1
        data = aos.req(url.path)
        res = data.fetch(:json)
    Severity: Major
    Found in include/mailing_list.rb and 1 other location - About 1 hr to fix
    include/mailing_list.rb on lines 184..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method update has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def update(data)
    begin
      res = aos.req_json("v1/subscribers/queue", :post, json: [data.merge(:Id => self.data(:id))])
      url = URI.parse(res["Result"]["PollURL"])
      result = nil
    Severity: Minor
    Found in include/subscriber.rb - About 1 hr to fix

      Method remove_all_subscribers has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def remove_all_subscribers
    data = aos.req("v1/mailinglists/#{self.data(:id)}/subscriptions/all", :delete)
    res = data.fetch(:json)

    unless res["Code"] == 1
      Severity: Minor
      Found in include/mailing_list.rb - About 1 hr to fix

        Method delete has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def delete
    res = aos.req_json("v1/mailinglists/", :delete, json: [data(:id)])

    url = URI.parse(res["Result"]["PollURL"])
    result = nil
        Severity: Minor
        Found in include/mailing_list.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method list_for has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def list_for(resource_url, resource_url_with_dates, resource_name, args = {})
    # OptOut counting does not work :-( We will have to do the date request to fix this...
    # If date-arguments are given, we will have to use the date request.
    if args[:date_from] || args[:date_to] || resource_name == "OptOut"
      return list_for_with_dates(resource_url_with_dates, resource_name, args)
        Severity: Minor
        Found in include/sending.rb - About 1 hr to fix

          Method parse_obj has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def parse_obj(obj)
    if obj.is_a?(Array)
      ret = []
      obj.each do |obj_i|
        ret << parse_obj(obj_i)
          Severity: Minor
          Found in lib/apsis-on-steroids.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method remove_all_subscribers has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def remove_all_subscribers
    data = aos.req("v1/mailinglists/#{self.data(:id)}/subscriptions/all", :delete)
    res = data.fetch(:json)

    unless res["Code"] == 1
          Severity: Minor
          Found in include/mailing_list.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method list_for has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def list_for(resource_url, resource_url_with_dates, resource_name, args = {})
    # OptOut counting does not work :-( We will have to do the date request to fix this...
    # If date-arguments are given, we will have to use the date request.
    if args[:date_from] || args[:date_to] || resource_name == "OptOut"
      return list_for_with_dates(resource_url_with_dates, resource_name, args)
          Severity: Minor
          Found in include/sending.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method parse_json_response has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def parse_json_response(response)
    # Throw custom JSON error for debugging if the JSON was corrupt (this actually happens!).
    begin
      json = JSON.parse(response.body)
    rescue JSON::ParserError
          Severity: Minor
          Found in lib/apsis-on-steroids.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method create_subscribers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def create_subscribers(data)
    res = aos.req_json("v1/subscribers/mailinglist/#{data(:id)}/queue", :post, json: data)

    url = URI.parse(res["Result"]["PollURL"])
    data_subscribers = nil
          Severity: Minor
          Found in include/mailing_list.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                return obj
          Severity: Major
          Found in lib/apsis-on-steroids.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return obj
            Severity: Major
            Found in lib/apsis-on-steroids.rb - About 30 mins to fix

              Method read_queued_response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                def read_queued_response(url)
    uri = URI.parse(url)

    Timeout.timeout(300) do
      loop do
              Severity: Minor
              Found in lib/apsis-on-steroids.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language