Sign upLogin

kaspernj/baza

View on GitHub
Star
lib/baza/driver/sqlite3/table.rb

Summary

Maintainability
F
3 days
Test Coverage

Method copy has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

  def copy(args = {})
    temp_name = "temptable_#{Time.now.to_f.to_s.hash}"
    clone(temp_name)
    cols_cur = columns
    @db.query("DROP TABLE `#{name}`")
Severity: Minor
Found in lib/baza/driver/sqlite3/table.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File table.rb has 342 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Baza::Driver::Sqlite3::Table < Baza::Table # rubocop:disable Metrics/ClassLength
  attr_reader :name, :type

  def initialize(args)
    @db = args.fetch(:db)
Severity: Minor
Found in lib/baza/driver/sqlite3/table.rb - About 4 hrs to fix

    Method create_indexes has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

      def create_indexes(index_arr, args = nil)
    ret = [] if args && args[:return_sql]

    index_arr.each do |index_data|
      if index_data.is_a?(String) || index_data.is_a?(Symbol)
    Severity: Minor
    Found in lib/baza/driver/sqlite3/table.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class Table has 26 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Baza::Driver::Sqlite3::Table < Baza::Table # rubocop:disable Metrics/ClassLength
  attr_reader :name, :type

  def initialize(args)
    @db = args.fetch(:db)
    Severity: Minor
    Found in lib/baza/driver/sqlite3/table.rb - About 3 hrs to fix

      Method create_column_programmatic has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        def create_column_programmatic(col_data)
    temp_name = "temptable_#{Time.now.to_f.to_s.hash}"
    clone(temp_name)
    cols_cur = columns
    @db.query("DROP TABLE `#{name}`")
      Severity: Minor
      Found in lib/baza/driver/sqlite3/table.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method indexes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def indexes
    @db.indexes
    ret = [] unless block_given?

    @db.query("PRAGMA index_list(#{@db.quote_table(name)})") do |d_indexes|
      Severity: Minor
      Found in lib/baza/driver/sqlite3/table.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method copy has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def copy(args = {})
    temp_name = "temptable_#{Time.now.to_f.to_s.hash}"
    clone(temp_name)
    cols_cur = columns
    @db.query("DROP TABLE `#{name}`")
      Severity: Minor
      Found in lib/baza/driver/sqlite3/table.rb - About 1 hr to fix

        Method clone has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def clone(newname, args = nil)
    raise "Invalid name." if newname.to_s.strip.empty?

    sql = "CREATE TABLE `#{newname}` ("
    first = true
        Severity: Minor
        Found in lib/baza/driver/sqlite3/table.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method clone has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def clone(newname, args = nil)
    raise "Invalid name." if newname.to_s.strip.empty?

    sql = "CREATE TABLE `#{newname}` ("
    first = true
        Severity: Minor
        Found in lib/baza/driver/sqlite3/table.rb - About 1 hr to fix

          Method create_indexes has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def create_indexes(index_arr, args = nil)
    ret = [] if args && args[:return_sql]

    index_arr.each do |index_data|
      if index_data.is_a?(String) || index_data.is_a?(Symbol)
          Severity: Minor
          Found in lib/baza/driver/sqlite3/table.rb - About 1 hr to fix

            Method indexes has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def indexes
    @db.indexes
    ret = [] unless block_given?

    @db.query("PRAGMA index_list(#{@db.quote_table(name)})") do |d_indexes|
            Severity: Minor
            Found in lib/baza/driver/sqlite3/table.rb - About 1 hr to fix

              Method create_column_programmatic has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def create_column_programmatic(col_data)
    temp_name = "temptable_#{Time.now.to_f.to_s.hash}"
    clone(temp_name)
    cols_cur = columns
    @db.query("DROP TABLE `#{name}`")
              Severity: Minor
              Found in lib/baza/driver/sqlite3/table.rb - About 1 hr to fix

                Method index has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  def index(index_name)
    index_name = index_name.to_s

    if (index = @indexes_list[index_name])
      return index
                Severity: Minor
                Found in lib/baza/driver/sqlite3/table.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method columns has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  def columns
    @db.columns
    ret = []

    @db.query("PRAGMA table_info(#{@db.quote_table(name)})") do |d_cols|
                Severity: Minor
                Found in lib/baza/driver/sqlite3/table.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                  def data
    ret = {
      name: name,
      columns: [],
      indexes: []
                Severity: Minor
                Found in lib/baza/driver/sqlite3/table.rb and 1 other location - About 35 mins to fix
                lib/baza/driver/mysql/table.rb on lines 304..319

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status