Sign upLogin

keboola/juicer

View on GitHub
Star

Showing 60 of 60 total issues

Function download has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function download(RestRequest $request)
    {
        try {
            $response = $this->client->send($this->guzzleRequestFactory->create($request));
            try {
Severity: Minor
Found in src/Client/RestClient.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getNextRequest has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function getNextRequest(RestClient $client, JobConfig $jobConfig, $response, array $data): ?RestRequest
    {
        if (empty($data)) {
            $this->reset();
            $this->logger->info('No data in response, stopping scrolling.');
Severity: Minor
Found in src/Pagination/CursorScroller.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method download has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function download(RestRequest $request)
    {
        try {
            $response = $this->client->send($this->guzzleRequestFactory->create($request));
            try {
Severity: Minor
Found in src/Client/RestClient.php - About 1 hr to fix

    Function __construct has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct(array $config)
    {
        if (empty($config['id'])) {
            $config['id'] = md5(serialize($config));
        }
    Severity: Minor
    Found in src/Config/JobConfig.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __construct has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct(ScrollerInterface $scroller, array $config, LoggerInterface $logger)
    {
        if (!empty($config['nextPageFlag'])) {
            if (empty($config['nextPageFlag']['field'])) {
                throw new UserException("'field' has to be specified for 'nextPageFlag'");
    Severity: Minor
    Found in src/Pagination/Decorator/HasMoreScrollerDecorator.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __construct has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct(array $config)
    {
        if (!isset($config['endpoint']) || !is_string($config['endpoint'])) {
            throw new UserException('The "endpoint" property must be specified in request as a string.');
        }
    Severity: Minor
    Found in src/Client/RestRequest.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __construct has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct(
        LoggerInterface $logger,
        array $metadata,
        int $compatLevel,
        int $cacheMemoryLimit = 2000000
    Severity: Minor
    Found in src/Parser/Json.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __construct has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct(Config $config, LoggerInterface $logger, ?ParserInterface $fallbackParser = null)
    {
        if (empty($config->getAttribute('mappings'))) {
            throw new UserException('Cannot initialize JSON Mapper with no mapping');
        }
    Severity: Minor
    Found in src/Parser/JsonMap.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct(Config $config, LoggerInterface $logger, ?ParserInterface $fallbackParser = null)
    {
        if (empty($config->getAttribute('mappings'))) {
            throw new UserException('Cannot initialize JSON Mapper with no mapping');
        }
    Severity: Minor
    Found in src/Parser/JsonMap.php - About 1 hr to fix

      Method __construct has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct(
        LoggerInterface $logger,
        array $metadata,
        int $compatLevel,
        int $cacheMemoryLimit = 2000000
      Severity: Minor
      Found in src/Parser/Json.php - About 1 hr to fix

        Function __construct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __construct(ScrollerInterface $scroller, array $config, LoggerInterface $logger)
    {
        parent::__construct($scroller, $logger);
        if (!empty($config['limitStop'])) {
            if (empty($config['limitStop']['field']) && empty($config['limitStop']['count'])) {
        Severity: Minor
        Found in src/Pagination/Decorator/LimitStopScrollerDecorator.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function create(RestRequest $restRequest): RequestInterface
    {
        $body = null;
        $headers = $restRequest->getHeaders();
        switch ($restRequest->getMethod()) {
        Severity: Minor
        Found in src/Client/GuzzleRequestFactory.php - About 1 hr to fix

          Method __construct has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function __construct(array $config)
    {
        if (empty($config['id'])) {
            $config['id'] = md5(serialize($config));
        }
          Severity: Minor
          Found in src/Config/JobConfig.php - About 1 hr to fix

            Method getNextRequest has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getNextRequest(RestClient $client, JobConfig $jobConfig, $response, array $data): ?RestRequest
    {
        if (empty($data)) {
            $this->reset();
            $this->logger->info('No data in response, stopping scrolling.');
            Severity: Minor
            Found in src/Pagination/CursorScroller.php - About 1 hr to fix

              Method __construct has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function __construct(ScrollerInterface $scroller, array $config, LoggerInterface $logger)
    {
        if (!empty($config['nextPageFlag'])) {
            if (empty($config['nextPageFlag']['field'])) {
                throw new UserException("'field' has to be specified for 'nextPageFlag'");
              Severity: Minor
              Found in src/Pagination/Decorator/HasMoreScrollerDecorator.php - About 1 hr to fix

                Function handleException has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function handleException(Throwable $e, ?ResponseInterface $response): ?stdClass
    {
        if (($response && in_array($response->getStatusCode(), $this->ignoreErrors)) ||
            in_array($e->getCode(), $this->ignoreErrors)
        ) {
                Severity: Minor
                Found in src/Client/RestClient.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method getNextRequest has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getNextRequest(RestClient $client, JobConfig $jobConfig, $response, array $data): ?RestRequest
    {
        $nextUrl = getDataFromPath($this->urlParam, $response, '.');

        if (empty($nextUrl)) {
                Severity: Minor
                Found in src/Pagination/ZendeskResponseUrlScroller.php - About 1 hr to fix

                  Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          LoggerInterface $logger,
        string $baseUri,
        array $guzzleConfig = [],
        array $retryConfig = [],
        array $defaultOptions = [],
                  Severity: Minor
                  Found in src/Client/RestClient.php - About 45 mins to fix

                    Function decider has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function decider(
        int $retries,
        RequestInterface $request,
        ?ResponseInterface $response,
        ?Throwable $exception
                    Severity: Minor
                    Found in src/Retry/RetryHandler.php - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    The class ScrollerFactory has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13.
                    Open

                    class ScrollerFactory
{
    public static function getScroller(array $config, ?LoggerInterface $logger = null): ScrollerInterface
    {
        $scroller = self::createScroller($config, $logger ?? new NullLogger);
                    Severity: Minor
                    Found in src/Pagination/ScrollerFactory.php by phpmd

                    CouplingBetweenObjects

                    Since: 1.1.0

                    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

                    Example

                    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

                    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

                    Severity
                    Category
                    Status
                    Source
                    Language