Sign upLogin

keboola/php-utils

View on GitHub
Star
src/Keboola/Utils/httpBuildUrl.php

Summary

Maintainability
A
0 mins
Test Coverage

The function httpBuildUrl() has an NPath complexity of 208. The configured NPath complexity threshold is 200.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The function httpBuildUrl() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method httpBuildUrl uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

    } else {
        $url = "";
    }
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The parameter $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parse_url is not named in camelCase.
Open

function httpBuildUrl(array $parse_url)
{
    // Skip if the URL is relative
    if (!empty($parse_url["scheme"]) && !empty($parse_url["host"])) {
        // scheme - e.g. http
Severity: Minor
Found in src/Keboola/Utils/httpBuildUrl.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status