kedder/openvario-shell

View on GitHub
src/ovshell_connman/agentiface.py

Summary

Maintainability
A
2 hrs
Test Coverage

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

        assert len(var.type.children) == 1
Severity: Info
Found in src/ovshell_connman/agentiface.py by bandit

Function unpack_variants has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def unpack_variants(var: Union[Variant, Any], tp: Optional[str] = None) -> Any:
    if not isinstance(var, Variant):
        if tp is None:
            return var
        var = Variant(tp, var)
Severity: Minor
Found in src/ovshell_connman/agentiface.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return [unpack_variants(v, childtype) for v in var.value]
Severity: Major
Found in src/ovshell_connman/agentiface.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return var.value
    Severity: Major
    Found in src/ovshell_connman/agentiface.py - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status