Sign upLogin

kegi/netscape-cookie-file-handler

View on GitHub
Star
src/NetscapeCookieFileHandler/Persister/Persister.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function generateFileOutput has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    private function generateFileOutput(
        CookieCollectionInterface $cookies
    ) {
        $output = '';
Severity: Minor
Found in src/NetscapeCookieFileHandler/Persister/Persister.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function persist has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function persist(
        CookieCollectionInterface $cookies,
        string $filename
    ) : PersisterInterface {
        if (empty($this->getConfiguration()->getCookieDir())) {
Severity: Minor
Found in src/NetscapeCookieFileHandler/Persister/Persister.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method persist has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function persist(
        CookieCollectionInterface $cookies,
        string $filename
    ) : PersisterInterface {
        if (empty($this->getConfiguration()->getCookieDir())) {
Severity: Minor
Found in src/NetscapeCookieFileHandler/Persister/Persister.php - About 1 hr to fix

    Method generateFileOutput has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function generateFileOutput(
        CookieCollectionInterface $cookies
    ) {
        $output = '';
    Severity: Minor
    Found in src/NetscapeCookieFileHandler/Persister/Persister.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status