kenjij/darksky-ruby

View on GitHub

Showing 69 of 69 total issues

Class has too many lines. [140/100]
Open

  class HTTP
    METHOD_HTTP_CLASS = {
      get: Net::HTTP::Get,
      put: Net::HTTP::Put,
      patch: Net::HTTP::Patch,
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [24/10]
Open

    def operate(method, path: nil, params: nil, body: nil, query: nil)
      uri = uri_with_path(path)
      case method
      when :get, :delete
        if params
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [21/10]
Open

    def handle_response(res)
      if res.connection_close?
        logger.info('HTTP response header says connection close; closing session now')
        close
      end
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for send is too high. [25.1/15]
Open

    def send(req)
      inject_headers_to(req)
      unless http.started?
        logger.info('HTTP session not started; starting now')
        http.start
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for redirect is too high. [22.91/15]
Open

    def redirect(method, uri, params: nil, body: nil, query: nil)
      if uri.host == init_uri.host && uri.port == init_uri.port
        logger.info("Local #{method.upcase} redirect, reusing HTTP session")
        new_http = http
      else
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [16/10]
Open

    def redirect(method, uri, params: nil, body: nil, query: nil)
      if uri.host == init_uri.host && uri.port == init_uri.port
        logger.info("Local #{method.upcase} redirect, reusing HTTP session")
        new_http = http
      else
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for handle_response is too high. [20.45/15]
Open

    def handle_response(res)
      if res.connection_close?
        logger.info('HTTP response header says connection close; closing session now')
        close
      end
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for operate is too high. [18.57/15]
Open

    def operate(method, path: nil, params: nil, body: nil, query: nil)
      uri = uri_with_path(path)
      case method
      when :get, :delete
        if params
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for operate is too high. [8/6]
Open

    def operate(method, path: nil, params: nil, body: nil, query: nil)
      uri = uri_with_path(path)
      case method
      when :get, :delete
        if params
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Assignment Branch Condition size for initialize is too high. [16.19/15]
Open

    def initialize(url, hdrs = nil)
      @logger = Neko.logger
      @init_uri = URI(url)
      raise ArgumentError, 'Invalid URL' unless @init_uri.class <= URI::HTTP
      @http = Net::HTTP.new(init_uri.host, init_uri.port)
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Perceived complexity for operate is too high. [8/7]
Open

    def operate(method, path: nil, params: nil, body: nil, query: nil)
      uri = uri_with_path(path)
      case method
      when :get, :delete
        if params
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method operate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def operate(method, path: nil, params: nil, body: nil, query: nil)
      uri = uri_with_path(path)
      case method
      when :get, :delete
        if params
Severity: Minor
Found in lib/darksky-ruby/http.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Freeze mutable objects assigned to constants.
Open

  DARKSKY_PATH_TEMPLATE = '/forecast/%{key}/%{loc}'
Severity: Minor
Found in lib/darksky-ruby/api.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Use %q only for strings that contain both single quotes and double quotes.
Open

  s.description   = %q{Dark Sky gem written in pure Ruby without any external dependency.}
Severity: Minor
Found in darksky-ruby.gemspec by rubocop

Space inside } missing.
Open

api.blocks = {minutely: false, hourly: false, daily: false, alerts: false, flags: false}
Severity: Minor
Found in bin/darksky by rubocop

Checks that braces used for hash literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that hash literals have
# surrounding space.

# bad
h = {a: 1, b: 2}

# good
h = { a: 1, b: 2 }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that hash literals have
# no surrounding space.

# bad
h = { a: 1, b: 2 }

# good
h = {a: 1, b: 2}

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# hash braces, with the exception that successive left
# braces or right braces are collapsed together in nested hashes.

# bad
h = { a: { b: 2 } }

# good
h = { a: { b: 2 }}

Favor format over String#%.
Open

    path = DARKSKY_PATH_TEMPLATE % {key: key, loc: loc}
Severity: Minor
Found in lib/darksky-ruby/api.rb by rubocop

This cop enforces the use of a single string formatting utility. Valid options include Kernel#format, Kernel#sprintf and String#%.

The detection of String#% cannot be implemented in a reliable manner for all cases, so only two scenarios are considered - if the first argument is a string literal and if the second argument is an array literal.

Example: EnforcedStyle: format(default)

# bad
puts sprintf('%10s', 'hoge')
puts '%10s' % 'hoge'

# good
puts format('%10s', 'hoge')

Example: EnforcedStyle: sprintf

# bad
puts format('%10s', 'hoge')
puts '%10s' % 'hoge'

# good
puts sprintf('%10s', 'hoge')

Example: EnforcedStyle: percent

# bad
puts format('%10s', 'hoge')
puts sprintf('%10s', 'hoge')

# good
puts '%10s' % 'hoge'

Freeze mutable objects assigned to constants.
Open

  VERSION = '1.0.2'
Severity: Minor
Found in lib/darksky-ruby/api.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Redundant return detected.
Open

      return data
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

required_ruby_version (2.0, declared in darksky-ruby.gemspec) and TargetRubyVersion (2.1, declared in .rubocop.yml) should be equal.
Open

  s.required_ruby_version = '>= 2.0'
Severity: Minor
Found in darksky-ruby.gemspec by rubocop

Checks that required_ruby_version of gemspec and TargetRubyVersion of .rubocop.yml are equal. Thereby, RuboCop to perform static analysis working on the version required by gemspec.

Example:

# When `TargetRubyVersion` of .rubocop.yml is `2.3`.

# bad
Gem::Specification.new do |spec|
  spec.required_ruby_version = '>= 2.2.0'
end

# bad
Gem::Specification.new do |spec|
  spec.required_ruby_version = '>= 2.4.0'
end

# good
Gem::Specification.new do |spec|
  spec.required_ruby_version = '>= 2.3.0'
end

# good
Gem::Specification.new do |spec|
  spec.required_ruby_version = '>= 2.3'
end

# good
Gem::Specification.new do |spec|
  spec.required_ruby_version = ['>= 2.3.0', '< 2.5.0']
end

Missing top-level module documentation comment.
Open

module Neko
Severity: Minor
Found in lib/darksky-ruby/http.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end
Severity
Category
Status
Source
Language