Sign upLogin

kete/kete

View on GitHub
Star
app/controllers/licenses_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Assignment Branch Condition size for install_license is too high. [24.37/15]
Open

  def install_license
    if params[:task]
      if @available_licenses.include?(params[:task])
        old_license_count = License.count
        ENV['RAILS_ENV'] = Rails.env
Severity: Minor
Found in app/controllers/licenses_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [17/10]
Open

  def install_license
    if params[:task]
      if @available_licenses.include?(params[:task])
        old_license_count = License.count
        ENV['RAILS_ENV'] = Rails.env
Severity: Minor
Found in app/controllers/licenses_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Perceived complexity for install_license is too high. [8/7]
Open

  def install_license
    if params[:task]
      if @available_licenses.include?(params[:task])
        old_license_count = License.count
        ENV['RAILS_ENV'] = Rails.env
Severity: Minor
Found in app/controllers/licenses_controller.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method install_license has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def install_license
    if params[:task]
      if @available_licenses.include?(params[:task])
        old_license_count = License.count
        ENV['RAILS_ENV'] = Rails.env
Severity: Minor
Found in app/controllers/licenses_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid the use of Perl-style backrefs.
Open

                              .collect { |task| task.name =~ /acts_as_licensed:import:(\w+)$/ ? $1 : nil }.compact
Severity: Minor
Found in app/controllers/licenses_controller.rb by rubocop

This cop looks for uses of Perl-style regexp match backreferences like $1, $2, etc.

Example:

# bad
puts $1

# good
puts Regexp.last_match(1)

There are no issues that match your filters.

Category
Status