app/helpers/account_helper.rb
Method random_alphanumeric
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def String.random_alphanumeric(size = 16)
(1..size).collect { (i = Kernel.rand(62); i += (i < 10 ? 48 : (i < 36 ? 55 : 61))).chr }.join
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Useless assignment to variable - i
. Open
Open
(1..size).collect { (i = Kernel.rand(62); i += (i < 10 ? 48 : (i < 36 ? 55 : 61))).chr }.join
- Read upRead up
- Exclude checks
This cop checks for every useless assignment to local variable in every
scope.
The basic idea for this cop was from the warning of ruby -cw
:
assigned but unused variable - foo
Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.
Example:
# bad
def some_method
some_var = 1
do_something
end
Example:
# good
def some_method
some_var = 1
do_something(some_var)
end
Ternary operators must not be nested. Prefer if
or else
constructs instead. Open
Open
(1..size).collect { (i = Kernel.rand(62); i += (i < 10 ? 48 : (i < 36 ? 55 : 61))).chr }.join
- Exclude checks
Do not use semicolons to terminate expressions. Open
Open
(1..size).collect { (i = Kernel.rand(62); i += (i < 10 ? 48 : (i < 36 ? 55 : 61))).chr }.join
- Read upRead up
- Exclude checks
This cop checks for multiple expressions placed on the same line. It also checks for lines terminated with a semicolon.
Example:
# bad
foo = 1; bar = 2;
baz = 3;
# good
foo = 1
bar = 2
baz = 3