app/helpers/members_helper.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method has too many lines. [49/10]
Open

  def admin_actions_correct_list_item(user, action_key, action_label, tool_count)
    html_string = ''

    case action_key
    when 'destroy'
Severity: Minor
Found in app/helpers/members_helper.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for admin_actions_correct_list_item is too high. [36.89/15]
Open

  def admin_actions_correct_list_item(user, action_key, action_label, tool_count)
    html_string = ''

    case action_key
    when 'destroy'
Severity: Minor
Found in app/helpers/members_helper.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method admin_actions_correct_list_item has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def admin_actions_correct_list_item(user, action_key, action_label, tool_count)
    html_string = ''

    case action_key
    when 'destroy'
Severity: Minor
Found in app/helpers/members_helper.rb - About 1 hr to fix

    Method admin_actions_correct_list_item has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def admin_actions_correct_list_item(user, action_key, action_label, tool_count)
        html_string = ''
    
        case action_key
        when 'destroy'
    Severity: Minor
    Found in app/helpers/members_helper.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Use the return of the conditional for variable assignment and comparison.
    Open

          if user_contributions == 0
            html_string = li_with_correct_class(tool_count) +
                          link_to(
                            action_label,
                            { action: :destroy, id: user, authenticity_token: form_authenticity_token },
    Severity: Minor
    Found in app/helpers/members_helper.rb by rubocop

    Use user_contributions.zero? instead of user_contributions == 0.
    Open

          if user_contributions == 0
    Severity: Minor
    Found in app/helpers/members_helper.rb by rubocop

    This cop checks for usage of comparison operators (==, >, <) to test numbers as zero, positive, or negative. These can be replaced by their respective predicate methods. The cop can also be configured to do the reverse.

    The cop disregards #nonzero? as it its value is truthy or falsey, but not true and false, and thus not always interchangeable with != 0.

    The cop ignores comparisons to global variables, since they are often populated with objects which can be compared with integers, but are not themselves Interger polymorphic.

    Example: EnforcedStyle: predicate (default)

    # bad
    
    foo == 0
    0 > foo
    bar.baz > 0
    
    # good
    
    foo.zero?
    foo.negative?
    bar.baz.positive?

    Example: EnforcedStyle: comparison

    # bad
    
    foo.zero?
    foo.negative?
    bar.baz.positive?
    
    # good
    
    foo == 0
    0 > foo
    bar.baz > 0

    Useless assignment to variable - html_string.
    Open

        html_string = ''
    Severity: Minor
    Found in app/helpers/members_helper.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    Useless assignment to variable - html_string.
    Open

          html_string = li_with_correct_class(tool_count) +
    Severity: Minor
    Found in app/helpers/members_helper.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    Useless assignment to variable - html_string.
    Open

            html_string = li_with_correct_class(tool_count) +
    Severity: Minor
    Found in app/helpers/members_helper.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    Useless assignment to variable - html_string.
    Open

            html_string = li_with_correct_class(tool_count) +
    Severity: Minor
    Found in app/helpers/members_helper.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    Useless assignment to variable - html_string.
    Open

            html_string = li_with_correct_class(tool_count) +
    Severity: Minor
    Found in app/helpers/members_helper.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    Useless assignment to variable - html_string.
    Open

            html_string = li_with_correct_class(tool_count) +
    Severity: Minor
    Found in app/helpers/members_helper.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    Use the return of the conditional for variable assignment and comparison.
    Open

          if !user.banned_at.nil?
            html_string = li_with_correct_class(tool_count) +
                          t('members_helper.admin_actions_correct_list_item.banned') +
                          user.banned_at.to_s(:euro_date_time) +
                          link_to(
    Severity: Minor
    Found in app/helpers/members_helper.rb by rubocop

    There are no issues that match your filters.

    Category
    Status