app/helpers/search_sources_helper.rb

Summary

Maintainability
A
35 mins
Test Coverage

Method has too many lines. [42/10]
Open

    define_method "#{syntax}_form_column" do |record, input_name|
      value =
        if params[:record] && params[:record][syntax]
          params[:record][syntax]
        elsif !record.new_record?

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [23/10]
Open

  def display_search_sources(search_text, options = {})
    @do_not_cache = options[:do_not_cache] || false
    html = ''

    conditions = {}

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for display_search_sources is too high. [21.21/15]
Open

  def display_search_sources(search_text, options = {})
    @do_not_cache = options[:do_not_cache] || false
    html = ''

    conditions = {}

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Block has too many lines. [44/25]
Open

  %i[or_syntax and_syntax not_syntax].each do |syntax|
    define_method "#{syntax}_form_column" do |record, input_name|
      value =
        if params[:record] && params[:record][syntax]
          params[:record][syntax]

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [42/25]
Open

    define_method "#{syntax}_form_column" do |record, input_name|
      value =
        if params[:record] && params[:record][syntax]
          params[:record][syntax]
        elsif !record.new_record?

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Method display_search_sources has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def display_search_sources(search_text, options = {})
    @do_not_cache = options[:do_not_cache] || false
    html = ''

    conditions = {}
Severity: Minor
Found in app/helpers/search_sources_helper.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Redundant else-clause.
Open

        else

Checks for empty else-clauses, possibly including comments and/or an explicit nil depending on the EnforcedStyle.

Example: EnforcedStyle: empty

# warn only on empty else

# bad
if condition
  statement
else
end

# good
if condition
  statement
else
  nil
end

# good
if condition
  statement
else
  statement
end

# good
if condition
  statement
end

Example: EnforcedStyle: nil

# warn on else with nil in it

# bad
if condition
  statement
else
  nil
end

# good
if condition
  statement
else
end

# good
if condition
  statement
else
  statement
end

# good
if condition
  statement
end

Example: EnforcedStyle: both (default)

# warn on empty else and else with nil in it

# bad
if condition
  statement
else
  nil
end

# bad
if condition
  statement
else
end

# good
if condition
  statement
else
  statement
end

# good
if condition
  statement
end

end at 71, 21 is not aligned with if at 65, 8.
Open

                     end

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

Use \ instead of + or << to concatenate those strings.
Open

    "<div id='search_sources'>" +

This cop checks for string literal concatenation at the end of a line.

Example:

# bad
some_str = 'ala' +
           'bala'

some_str = 'ala' <<
           'bala'

# good
some_str = 'ala' \
           'bala'

Pass &:to_s as an argument to collect instead of a block.
Open

      conditions[:conditions] = ['source_target IN (?)', targets.collect { |t| t.to_s }]

Use symbols as procs when possible.

Example:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

There are no issues that match your filters.

Category
Status