Sign upLogin

kete/kete

View on GitHub
Star
app/models/kete_flagging_methods.rb

Summary

Maintainability
A
0 mins
Test Coverage

Assignment Branch Condition size for public? is too high. [15.52/15]
Open

  def public?
    if is_a?(Comment)
      title != SystemSetting.blank_title && title != SystemSetting.no_public_version_title && commentable_private == false
    else
      title != SystemSetting.blank_title && title != SystemSetting.no_public_version_title
Severity: Minor
Found in app/models/kete_flagging_methods.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Interpolation in single quoted string detected. Use double quoted strings if you need interpolation.
Open

    tags.size > 0 && tags.join(',') =~ /(\#{SystemSetting.reviewed_flag})/
Severity: Minor
Found in app/models/kete_flagging_methods.rb by rubocop

This cop checks for interpolation in a single quoted string.

Example:

# bad

foo = 'something with #{interpolation} inside'

Example:

# good

foo = "something with #{interpolation} inside"

Interpolation in single quoted string detected. Use double quoted strings if you need interpolation.
Open

    tags.size > 0 && tags.join(',') =~ /(\#{SystemSetting.rejected_flag})/
Severity: Minor
Found in app/models/kete_flagging_methods.rb by rubocop

This cop checks for interpolation in a single quoted string.

Example:

# bad

foo = 'something with #{interpolation} inside'

Example:

# good

foo = "something with #{interpolation} inside"

Use tags.size.positive? instead of tags.size > 0.
Open

    tags.size > 0 && tags.join(',') =~ /(\#{SystemSetting.rejected_flag})/
Severity: Minor
Found in app/models/kete_flagging_methods.rb by rubocop

This cop checks for usage of comparison operators (==, >, <) to test numbers as zero, positive, or negative. These can be replaced by their respective predicate methods. The cop can also be configured to do the reverse.

The cop disregards #nonzero? as it its value is truthy or falsey, but not true and false, and thus not always interchangeable with != 0.

The cop ignores comparisons to global variables, since they are often populated with objects which can be compared with integers, but are not themselves Interger polymorphic.

Example: EnforcedStyle: predicate (default)

# bad

foo == 0
0 > foo
bar.baz > 0

# good

foo.zero?
foo.negative?
bar.baz.positive?

Example: EnforcedStyle: comparison

# bad

foo.zero?
foo.negative?
bar.baz.positive?

# good

foo == 0
0 > foo
bar.baz > 0

Use !empty? instead of size > 0.
Open

    tags.size > 0 && tags.join(',') =~ /(\#{SystemSetting.reviewed_flag})/
Severity: Minor
Found in app/models/kete_flagging_methods.rb by rubocop

This cop checks for numeric comparisons that can be replaced by a predicate method, such as receiver.length == 0, receiver.length > 0, receiver.length != 0, receiver.length < 1 and receiver.size == 0 that can be replaced by receiver.empty? and !receiver.empty.

Example:

# bad
[1, 2, 3].length == 0
0 == "foobar".length
array.length < 1
{a: 1, b: 2}.length != 0
string.length > 0
hash.size > 0

# good
[1, 2, 3].empty?
"foobar".empty?
array.empty?
!{a: 1, b: 2}.empty?
!string.empty?
!hash.empty?

Use tags.size.positive? instead of tags.size > 0.
Open

    tags.size > 0 && tags.join(',') =~ /(\#{SystemSetting.reviewed_flag})/
Severity: Minor
Found in app/models/kete_flagging_methods.rb by rubocop

This cop checks for usage of comparison operators (==, >, <) to test numbers as zero, positive, or negative. These can be replaced by their respective predicate methods. The cop can also be configured to do the reverse.

The cop disregards #nonzero? as it its value is truthy or falsey, but not true and false, and thus not always interchangeable with != 0.

The cop ignores comparisons to global variables, since they are often populated with objects which can be compared with integers, but are not themselves Interger polymorphic.

Example: EnforcedStyle: predicate (default)

# bad

foo == 0
0 > foo
bar.baz > 0

# good

foo.zero?
foo.negative?
bar.baz.positive?

Example: EnforcedStyle: comparison

# bad

foo.zero?
foo.negative?
bar.baz.positive?

# good

foo == 0
0 > foo
bar.baz > 0

Use tags.size.positive? instead of tags.size > 0.
Open

    tags.size > 0 && tags.join(',') !~ /(\#{already_moderated_flags.join('|')})/
Severity: Minor
Found in app/models/kete_flagging_methods.rb by rubocop

This cop checks for usage of comparison operators (==, >, <) to test numbers as zero, positive, or negative. These can be replaced by their respective predicate methods. The cop can also be configured to do the reverse.

The cop disregards #nonzero? as it its value is truthy or falsey, but not true and false, and thus not always interchangeable with != 0.

The cop ignores comparisons to global variables, since they are often populated with objects which can be compared with integers, but are not themselves Interger polymorphic.

Example: EnforcedStyle: predicate (default)

# bad

foo == 0
0 > foo
bar.baz > 0

# good

foo.zero?
foo.negative?
bar.baz.positive?

Example: EnforcedStyle: comparison

# bad

foo.zero?
foo.negative?
bar.baz.positive?

# good

foo == 0
0 > foo
bar.baz > 0

Use !empty? instead of size > 0.
Open

    tags.size > 0 && tags.join(',') =~ /(\#{SystemSetting.rejected_flag})/
Severity: Minor
Found in app/models/kete_flagging_methods.rb by rubocop

This cop checks for numeric comparisons that can be replaced by a predicate method, such as receiver.length == 0, receiver.length > 0, receiver.length != 0, receiver.length < 1 and receiver.size == 0 that can be replaced by receiver.empty? and !receiver.empty.

Example:

# bad
[1, 2, 3].length == 0
0 == "foobar".length
array.length < 1
{a: 1, b: 2}.length != 0
string.length > 0
hash.size > 0

# good
[1, 2, 3].empty?
"foobar".empty?
array.empty?
!{a: 1, b: 2}.empty?
!string.empty?
!hash.empty?

Interpolation in single quoted string detected. Use double quoted strings if you need interpolation.
Open

    tags.size > 0 && tags.join(',') !~ /(\#{already_moderated_flags.join('|')})/
Severity: Minor
Found in app/models/kete_flagging_methods.rb by rubocop

This cop checks for interpolation in a single quoted string.

Example:

# bad

foo = 'something with #{interpolation} inside'

Example:

# good

foo = "something with #{interpolation} inside"

Prefer !expression.nil? over expression != nil.
Open

      title != SystemSetting.blank_title && private_version_serialized != nil    # NOT NULL
Severity: Minor
Found in app/models/kete_flagging_methods.rb by rubocop

This cop checks for non-nil checks, which are usually redundant.

Example:

# bad
if x != nil
end

# good (when not allowing semantic changes)
# bad (when allowing semantic changes)
if !x.nil?
end

# good (when allowing semantic changes)
if x
end

Non-nil checks are allowed if they are the final nodes of predicate.

# good
def signed_in?
  !current_user.nil?
end

Prefer !expression.nil? over expression != nil.
Open

      title != SystemSetting.blank_title || description != nil    # is not null
Severity: Minor
Found in app/models/kete_flagging_methods.rb by rubocop

This cop checks for non-nil checks, which are usually redundant.

Example:

# bad
if x != nil
end

# good (when not allowing semantic changes)
# bad (when allowing semantic changes)
if !x.nil?
end

# good (when allowing semantic changes)
if x
end

Non-nil checks are allowed if they are the final nodes of predicate.

# good
def signed_in?
  !current_user.nil?
end

Use !empty? instead of size > 0.
Open

    tags.size > 0 && tags.join(',') !~ /(\#{already_moderated_flags.join('|')})/
Severity: Minor
Found in app/models/kete_flagging_methods.rb by rubocop

This cop checks for numeric comparisons that can be replaced by a predicate method, such as receiver.length == 0, receiver.length > 0, receiver.length != 0, receiver.length < 1 and receiver.size == 0 that can be replaced by receiver.empty? and !receiver.empty.

Example:

# bad
[1, 2, 3].length == 0
0 == "foobar".length
array.length < 1
{a: 1, b: 2}.length != 0
string.length > 0
hash.size > 0

# good
[1, 2, 3].empty?
"foobar".empty?
array.empty?
!{a: 1, b: 2}.empty?
!string.empty?
!hash.empty?

There are no issues that match your filters.

Category
Status