Sign upLogin

kete/kete

View on GitHub
Star
app/models/search_query.rb

Summary

Maintainability
A
0 mins
Test Coverage

Assignment Branch Condition size for initialize is too high. [21.47/15]
Open

  def initialize(params)
    @controller = params[:controller]
    @action = params[:action]

    # the string that the user typed into the search box
Severity: Minor
Found in app/models/search_query.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [14/10]
Open

  def initialize(params)
    @controller = params[:controller]
    @action = params[:action]

    # the string that the user typed into the search box
Severity: Minor
Found in app/models/search_query.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for to_hash is too high. [17.8/15]
Open

  def to_hash
    hash = {
      # target_basket: basket_name,
      controller_name_for_zoom_class: content_item_type
    }
Severity: Minor
Found in app/models/search_query.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

TODO found
Open

    #  TODO: put better, more descriptive name on these dates
Severity: Minor
Found in app/models/search_query.rb by fixme

Redundant curly braces around a hash parameter.
Open

    to_hash.merge({ controller_name_for_zoom_class: content_item_type })
Severity: Minor
Found in app/models/search_query.rb by rubocop

This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

Example: EnforcedStyle: braces

# The `braces` style enforces braces around all method
# parameters that are hashes.

# bad
some_method(x, y, a: 1, b: 2)

# good
some_method(x, y, {a: 1, b: 2})

Example: EnforcedStyle: no_braces (default)

# The `no_braces` style checks that the last parameter doesn't
# have braces around it.

# bad
some_method(x, y, {a: 1, b: 2})

# good
some_method(x, y, a: 1, b: 2)

Example: EnforcedStyle: context_dependent

# The `context_dependent` style checks that the last parameter
# doesn't have braces around it, but requires braces if the
# second to last parameter is also a hash literal.

# bad
some_method(x, y, {a: 1, b: 2})
some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)

# good
some_method(x, y, a: 1, b: 2)
some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})

Redundant else-clause.
Open

    else
Severity: Minor
Found in app/models/search_query.rb by rubocop

Checks for empty else-clauses, possibly including comments and/or an explicit nil depending on the EnforcedStyle.

Example: EnforcedStyle: empty

# warn only on empty else

# bad
if condition
  statement
else
end

# good
if condition
  statement
else
  nil
end

# good
if condition
  statement
else
  statement
end

# good
if condition
  statement
end

Example: EnforcedStyle: nil

# warn on else with nil in it

# bad
if condition
  statement
else
  nil
end

# good
if condition
  statement
else
end

# good
if condition
  statement
else
  statement
end

# good
if condition
  statement
end

Example: EnforcedStyle: both (default)

# warn on empty else and else with nil in it

# bad
if condition
  statement
else
  nil
end

# bad
if condition
  statement
else
end

# good
if condition
  statement
else
  statement
end

# good
if condition
  statement
end

There are no issues that match your filters.

Category
Status