lib/email_controller.rb

Summary

Maintainability
A
45 mins
Test Coverage

Assignment Branch Condition size for send_email is too high. [35.28/15]
Open

    def send_email
      if params[:contact].nil? || params[:contact][:subject].blank? || params[:contact][:message].blank?
        flash[:error] = I18n.t('email_controller_lib.send_email.need_subject_and_message')
        render template: 'email/contact'
      else
Severity: Minor
Found in lib/email_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [14/10]
Open

    def send_email
      if params[:contact].nil? || params[:contact][:subject].blank? || params[:contact][:message].blank?
        flash[:error] = I18n.t('email_controller_lib.send_email.need_subject_and_message')
        render template: 'email/contact'
      else
Severity: Minor
Found in lib/email_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method send_email has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def send_email
      if params[:contact].nil? || params[:contact][:subject].blank? || params[:contact][:message].blank?
        flash[:error] = I18n.t('email_controller_lib.send_email.need_subject_and_message')
        render template: 'email/contact'
      else
Severity: Minor
Found in lib/email_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      unless @contact_form_enabled
Severity: Minor
Found in lib/email_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Prefer Object#is_a? over Object#kind_of?.
Open

        if @recipient.kind_of? Array
Severity: Minor
Found in lib/email_controller.rb by rubocop

This cop enforces consistent use of Object#is_a? or Object#kind_of?.

Example: EnforcedStyle: is_a? (default)

# bad
var.kind_of?(Date)
var.kind_of?(Integer)

# good
var.is_a?(Date)
var.is_a?(Integer)

Example: EnforcedStyle: kind_of?

# bad
var.is_a?(Time)
var.is_a?(String)

# good
var.kind_of?(Time)
var.kind_of?(String)

Use the return of the conditional for variable assignment and comparison.
Open

      if klass.name == 'BasketsController'
        settings_method = :prepare_basket_contact_form
      else
        settings_method = :prepare_user_contact_form
      end
Severity: Minor
Found in lib/email_controller.rb by rubocop

Avoid multi-line ternary operators, use if or unless instead.
Open

        @current_basket == @site_basket ||
          @current_basket == @about_basket ? SystemSetting.pretty_site_name : @current_basket.name
Severity: Minor
Found in lib/email_controller.rb by rubocop

This cop checks for multi-line ternary op expressions.

Example:

# bad
a = cond ?
  b : c
a = cond ? b :
    c
a = cond ?
    b :
    c

# good
a = cond ? b : c
a =
  if cond
    b
  else
    c
  end

There are no issues that match your filters.

Category
Status