Sign upLogin

kete/kete

View on GitHub
Star
lib/generic_muted_worker_calling_helpers.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method has too many lines. [35/10]
Open

    def call_generic_muted_worker_with(options)
      return false if Rails.env == 'test'

      method_name = options.delete(:method_name)
      raise unless method_name
Severity: Minor
Found in lib/generic_muted_worker_calling_helpers.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for call_generic_muted_worker_with is too high. [31.72/15]
Open

    def call_generic_muted_worker_with(options)
      return false if Rails.env == 'test'

      method_name = options.delete(:method_name)
      raise unless method_name
Severity: Minor
Found in lib/generic_muted_worker_calling_helpers.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method call_generic_muted_worker_with has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def call_generic_muted_worker_with(options)
      return false if Rails.env == 'test'

      method_name = options.delete(:method_name)
      raise unless method_name
Severity: Minor
Found in lib/generic_muted_worker_calling_helpers.rb - About 1 hr to fix

    Method call_generic_muted_worker_with has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def call_generic_muted_worker_with(options)
      return false if Rails.env == 'test'

      method_name = options.delete(:method_name)
      raise unless method_name
    Severity: Minor
    Found in lib/generic_muted_worker_calling_helpers.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    TODO found
    Open

          # TODO: replace this by queueing
    Severity: Minor
    Found in lib/generic_muted_worker_calling_helpers.rb by fixme

    Redundant curly braces around a hash parameter.
    Open

          options = options.merge({ class_key => the_object }) if class_key
    Severity: Minor
    Found in lib/generic_muted_worker_calling_helpers.rb by rubocop

    This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

    Example: EnforcedStyle: braces

    # The `braces` style enforces braces around all method
# parameters that are hashes.

# bad
some_method(x, y, a: 1, b: 2)

# good
some_method(x, y, {a: 1, b: 2})

    Example: EnforcedStyle: no_braces (default)

    # The `no_braces` style checks that the last parameter doesn't
# have braces around it.

# bad
some_method(x, y, {a: 1, b: 2})

# good
some_method(x, y, a: 1, b: 2)

    Example: EnforcedStyle: context_dependent

    # The `context_dependent` style checks that the last parameter
# doesn't have braces around it, but requires braces if the
# second to last parameter is also a hash literal.

# bad
some_method(x, y, {a: 1, b: 2})
some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)

# good
some_method(x, y, a: 1, b: 2)
some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})

    There are no issues that match your filters.

    Category
    Status