Sign upLogin

kete/kete

View on GitHub
Star
lib/kete_authorization.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

  unless included_modules.include? KeteAuthorization
    def self.included(klass)
      klass.send :before_filter, :load_site_admin
      klass.send :before_filter, :load_tech_admin
      klass.send :before_filter, :load_basket_admin
Severity: Critical
Found in lib/kete_authorization.rb - About 3 hrs to fix

    Assignment Branch Condition size for load_at_least is too high. [20.62/15]
    Open

        def load_at_least(basket = nil)
      if !basket.nil?
        @at_least_site_admin_of_specified_basket ||= site_admin?
        @at_least_admin_of_specified_basket ||= basket_admin?(basket)
        @at_least_moderator_of_specified_basket ||= basket_moderator?(basket)
    Severity: Minor
    Found in lib/kete_authorization.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Method has too many lines. [13/10]
    Open

        def load_at_least(basket = nil)
      if !basket.nil?
        @at_least_site_admin_of_specified_basket ||= site_admin?
        @at_least_admin_of_specified_basket ||= basket_admin?(basket)
        @at_least_moderator_of_specified_basket ||= basket_moderator?(basket)
    Severity: Minor
    Found in lib/kete_authorization.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method load_at_least has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def load_at_least(basket = nil)
      if !basket.nil?
        @at_least_site_admin_of_specified_basket ||= site_admin?
        @at_least_admin_of_specified_basket ||= basket_admin?(basket)
        @at_least_moderator_of_specified_basket ||= basket_moderator?(basket)
    Severity: Minor
    Found in lib/kete_authorization.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    TODO found
    Open

        # TODO: prime for DRYing up with metaprogramming
    Severity: Minor
    Found in lib/kete_authorization.rb by fixme

    There are no issues that match your filters.

    Category
    Status