lib/kete_url_for.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Assignment Branch Condition size for fully_qualified_item_url is too high. [36.36/15]
Open

    def fully_qualified_item_url(options = {}, is_relation = false)
      host = options[:host] || SystemSetting.site_url
      item = options[:item]
      controller = options[:controller]
      urlified_name = options[:urlified_name]
Severity: Minor
Found in lib/kete_url_for.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [27/10]
Open

    def fully_qualified_item_url(options = {}, is_relation = false)
      host = options[:host] || SystemSetting.site_url
      item = options[:item]
      controller = options[:controller]
      urlified_name = options[:urlified_name]
Severity: Minor
Found in lib/kete_url_for.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Perceived complexity for fully_qualified_item_url is too high. [12/7]
Open

    def fully_qualified_item_url(options = {}, is_relation = false)
      host = options[:host] || SystemSetting.site_url
      item = options[:item]
      controller = options[:controller]
      urlified_name = options[:urlified_name]
Severity: Minor
Found in lib/kete_url_for.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method has too many lines. [15/10]
Open

    def url_for_dc_identifier(item, options = {})
      location = {
        controller: zoom_class_controller(item.class.name),
        action: 'show',
        id: item,
Severity: Minor
Found in lib/kete_url_for.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for fully_qualified_item_url is too high. [9/6]
Open

    def fully_qualified_item_url(options = {}, is_relation = false)
      host = options[:host] || SystemSetting.site_url
      item = options[:item]
      controller = options[:controller]
      urlified_name = options[:urlified_name]
Severity: Minor
Found in lib/kete_url_for.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method fully_qualified_item_url has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def fully_qualified_item_url(options = {}, is_relation = false)
      host = options[:host] || SystemSetting.site_url
      item = options[:item]
      controller = options[:controller]
      urlified_name = options[:urlified_name]
Severity: Minor
Found in lib/kete_url_for.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fully_qualified_item_url has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def fully_qualified_item_url(options = {}, is_relation = false)
      host = options[:host] || SystemSetting.site_url
      item = options[:item]
      controller = options[:controller]
      urlified_name = options[:urlified_name]
Severity: Minor
Found in lib/kete_url_for.rb - About 1 hr to fix

    Use the return of the conditional for variable assignment and comparison.
    Open

            if item.respond_to?(:private) && item.private?
              url += "#{controller}/show/#{item.id}?private=true"
            else
              url += "#{controller}/show/#{item.to_param}"
            end
    Severity: Minor
    Found in lib/kete_url_for.rb by rubocop

    include is used at the top level. Use inside class or module.
    Open

    include Utf8UrlFor
    Severity: Minor
    Found in lib/kete_url_for.rb by rubocop

    This cop checks that include, extend and prepend exists at the top level. Using these at the top level affects the behavior of Object. There will not be using include, extend and prepend at the top level. Let's use it inside class or module.

    Example:

    # bad
    include M
    
    class C
    end
    
    # bad
    extend M
    
    class C
    end
    
    # bad
    prepend M
    
    class C
    end
    
    # good
    class C
      include M
    end
    
    # good
    class C
      extend M
    end
    
    # good
    class C
      prepend M
    end

    include is used at the top level. Use inside class or module.
    Open

    include XmlHelpers
    Severity: Minor
    Found in lib/kete_url_for.rb by rubocop

    This cop checks that include, extend and prepend exists at the top level. Using these at the top level affects the behavior of Object. There will not be using include, extend and prepend at the top level. Let's use it inside class or module.

    Example:

    # bad
    include M
    
    class C
    end
    
    # bad
    extend M
    
    class C
    end
    
    # bad
    prepend M
    
    class C
    end
    
    # good
    class C
      include M
    end
    
    # good
    class C
      extend M
    end
    
    # good
    class C
      prepend M
    end

    Use the return of the conditional for variable assignment and comparison.
    Open

            if item.should_save_to_private_zoom?
              url += "#{commented_on_item.id}?private=true"
            else
              url += commented_on_item.to_param.to_s
            end
    Severity: Minor
    Found in lib/kete_url_for.rb by rubocop

    include is used at the top level. Use inside class or module.
    Open

    include ZoomControllerHelpers
    Severity: Minor
    Found in lib/kete_url_for.rb by rubocop

    This cop checks that include, extend and prepend exists at the top level. Using these at the top level affects the behavior of Object. There will not be using include, extend and prepend at the top level. Let's use it inside class or module.

    Example:

    # bad
    include M
    
    class C
    end
    
    # bad
    extend M
    
    class C
    end
    
    # bad
    prepend M
    
    class C
    end
    
    # good
    class C
      include M
    end
    
    # good
    class C
      extend M
    end
    
    # good
    class C
      prepend M
    end

    Convert if nested inside else to elsif.
    Open

            if item.respond_to?(:private) && item.private?
    Severity: Minor
    Found in lib/kete_url_for.rb by rubocop

    If the else branch of a conditional consists solely of an if node, it can be combined with the else to become an elsif. This helps to keep the nesting level from getting too deep.

    Example:

    # bad
    if condition_a
      action_a
    else
      if condition_b
        action_b
      else
        action_c
      end
    end
    
    # good
    if condition_a
      action_a
    elsif condition_b
      action_b
    else
      action_c
    end

    There are no issues that match your filters.

    Category
    Status