Sign upLogin

kete/kete

View on GitHub
Star
lib/old_tasks/user_export_import.rake

Summary

Maintainability
Test Coverage

Block has too many lines. [63/25]
Open

namespace :kete do
  namespace :export do
    desc 'Export the Users table to a Yaml formatted file'
    task users: :environment do
      yaml = ''
Severity: Minor
Found in lib/old_tasks/user_export_import.rake by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [27/25]
Open

  namespace :export do
    desc 'Export the Users table to a Yaml formatted file'
    task users: :environment do
      yaml = ''
      User.all.each do |user|
Severity: Minor
Found in lib/old_tasks/user_export_import.rake by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Do not use semicolons to terminate expressions.
Open

      p "ERROR: Could not find RAILS_ROOT/tmp/#{filename}"; exit
Severity: Minor
Found in lib/old_tasks/user_export_import.rake by rubocop

This cop checks for multiple expressions placed on the same line. It also checks for lines terminated with a semicolon.

Example:

# bad
foo = 1; bar = 2;
baz = 3;

# good
foo = 1
bar = 2
baz = 3

Redundant curly braces around a hash parameter.
Open

        user_data = user.last['fields'].merge({ 'agree_to_terms' => '1', 'security_code' => 'bleh' })
Severity: Minor
Found in lib/old_tasks/user_export_import.rake by rubocop

This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

Example: EnforcedStyle: braces

# The `braces` style enforces braces around all method
# parameters that are hashes.

# bad
some_method(x, y, a: 1, b: 2)

# good
some_method(x, y, {a: 1, b: 2})

Example: EnforcedStyle: no_braces (default)

# The `no_braces` style checks that the last parameter doesn't
# have braces around it.

# bad
some_method(x, y, {a: 1, b: 2})

# good
some_method(x, y, a: 1, b: 2)

Example: EnforcedStyle: context_dependent

# The `context_dependent` style checks that the last parameter
# doesn't have braces around it, but requires braces if the
# second to last parameter is also a hash literal.

# bad
some_method(x, y, {a: 1, b: 2})
some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)

# good
some_method(x, y, a: 1, b: 2)
some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})

Use User.count(conditions: ['login = ?', user_data['login']]).positive? instead of User.count(conditions: ['login = ?', user_data['login']]) > 0.
Open

        if User.count(conditions: ['login = ?', user_data['login']]) > 0
Severity: Minor
Found in lib/old_tasks/user_export_import.rake by rubocop

This cop checks for usage of comparison operators (==, >, <) to test numbers as zero, positive, or negative. These can be replaced by their respective predicate methods. The cop can also be configured to do the reverse.

The cop disregards #nonzero? as it its value is truthy or falsey, but not true and false, and thus not always interchangeable with != 0.

The cop ignores comparisons to global variables, since they are often populated with objects which can be compared with integers, but are not themselves Interger polymorphic.

Example: EnforcedStyle: predicate (default)

# bad

foo == 0
0 > foo
bar.baz > 0

# good

foo.zero?
foo.negative?
bar.baz.positive?

Example: EnforcedStyle: comparison

# bad

foo.zero?
foo.negative?
bar.baz.positive?

# good

foo == 0
0 > foo
bar.baz > 0

Favor unless over if for negative conditions.
Open

            next if !basket
Severity: Minor
Found in lib/old_tasks/user_export_import.rake by rubocop

Checks for uses of if with a negated condition. Only ifs without else are considered. There are three different styles:

- both
- prefix
- postfix

Example: EnforcedStyle: both (default)

# enforces `unless` for `prefix` and `postfix` conditionals

# bad

if !foo
  bar
end

# good

unless foo
  bar
end

# bad

bar if !foo

# good

bar unless foo

Example: EnforcedStyle: prefix

# enforces `unless` for just `prefix` conditionals

# bad

if !foo
  bar
end

# good

unless foo
  bar
end

# good

bar if !foo

Example: EnforcedStyle: postfix

# enforces `unless` for just `postfix` conditionals

# bad

bar if !foo

# good

bar unless foo

# good

if !foo
  bar
end

Favor unless over if for negative conditions.
Open

    if !File.exist?("#{RAILS_ROOT}/tmp/#{filename}")
      p "ERROR: Could not find RAILS_ROOT/tmp/#{filename}"; exit
    end
Severity: Minor
Found in lib/old_tasks/user_export_import.rake by rubocop

Checks for uses of if with a negated condition. Only ifs without else are considered. There are three different styles:

- both
- prefix
- postfix

Example: EnforcedStyle: both (default)

# enforces `unless` for `prefix` and `postfix` conditionals

# bad

if !foo
  bar
end

# good

unless foo
  bar
end

# bad

bar if !foo

# good

bar unless foo

Example: EnforcedStyle: prefix

# enforces `unless` for just `prefix` conditionals

# bad

if !foo
  bar
end

# good

unless foo
  bar
end

# good

bar if !foo

Example: EnforcedStyle: postfix

# enforces `unless` for just `postfix` conditionals

# bad

bar if !foo

# good

bar unless foo

# good

if !foo
  bar
end

Use the return of the conditional for variable assignment and comparison.
Open

          if field == 'extended_content'
            yaml += "    #{field}: |\n      #{value}\n"
          else
            yaml += "    #{field}: #{value}\n"
          end
Severity: Minor
Found in lib/old_tasks/user_export_import.rake by rubocop

There are no issues that match your filters.

Category
Status