Sign upLogin

kete/kete

View on GitHub
Star
lib/resize_as_jpeg_when_necessary.rb

Summary

Maintainability
A
35 mins
Test Coverage

Method thumbnail_name_for has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def thumbnail_name_for(thumbnail = nil)
      name = super
      # if this not the original and should be converted to a jpeg
      # check if the name has a thumbnail naming pattern in it
      # rather than hardcode the pattern, we derive it from attachment_fu's thumbnails setting
Severity: Minor
Found in lib/resize_as_jpeg_when_necessary.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use each_key instead of keys.each.
Open

        attachment_options[:thumbnails].keys.each do |key|
Severity: Minor
Found in lib/resize_as_jpeg_when_necessary.rb by rubocop

This cop checks for uses of each_key and each_value Hash methods.

Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.

Example:

# bad
hash.keys.each { |k| p k }
hash.values.each { |v| p v }
hash.each { |k, _v| p k }
hash.each { |_k, v| p v }

# good
hash.each_key { |k| p k }
hash.each_value { |v| p v }

%w-literals should be delimited by [ and ].
Open

        !%w(gif jpg jpeg png).include?(ext.downcase) && rmagick_can_read_extension?(ext)
Severity: Minor
Found in lib/resize_as_jpeg_when_necessary.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

There are no issues that match your filters.

Category
Status