Sign upLogin

kevinanielsen/flags-game

View on GitHub
Star

Showing 11 of 13 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Confirmed

  if (!success) {
    const now = Date.now();
    const retryAfter = Math.floor((reset - now) / 1000);
    return new NextResponse(`Too many requests. IP: ${ip}`, {
      status: 429,
Severity: Major
Found in app/api/score/route.ts and 1 other location - About 2 hrs to fix
app/api/top-scores/route.ts on lines 14..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Confirmed

  if (!success) {
    const now = Date.now();
    const retryAfter = Math.floor((reset - now) / 1000);
    return new NextResponse(`Too many requests. IP: ${ip}`, {
      status: 429,
Severity: Major
Found in app/api/top-scores/route.ts and 1 other location - About 2 hrs to fix
app/api/score/route.ts on lines 20..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function LeaderBoard has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const LeaderBoard = () => {
  const { data, isLoading, error } = useQuery({
    queryKey: ["top-scores"],
    queryFn: async () => {
      const res = await axios.get<TScore[]>("/api/top-scores");
Severity: Minor
Found in components/leaderboard.tsx - About 1 hr to fix

Function POST has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function POST(req: NextRequest) {
  const headersList = headers();
  const ip = headersList.get("x-forwarded-for") ?? "127.0.0.1";

  const { success, reset } = await ratelimit.limit(ip);
Severity: Minor
Found in app/api/score/route.ts - About 1 hr to fix

Function handleSubmit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const handleSubmit = (e: FormEvent<HTMLFormElement>) => {
    e.preventDefault();

    if (name.length === 0) {
      toast({ title: "Missing Name", variant: "error" });
Severity: Minor
Found in components/game/end-game-input.tsx - About 1 hr to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Confirmed

const Loading = () => {
  return (
    <div className="absolute h-screen w-screen top-0 left-0 bg-slate-950/30 z-50">
      <CircularProgress size="lg" aria-label="Loading..." />
    </div>
Severity: Minor
Found in app/loading.tsx and 1 other location - About 40 mins to fix
app/game/loading.tsx on lines 5..11

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Confirmed

const Loading = () => {
  return (
    <div className="absolute h-screen w-screen top-0 left-0 bg-slate-950/30 z-50">
      <CircularProgress size="lg" aria-label="Loading..." />
    </div>
Severity: Minor
Found in app/game/loading.tsx and 1 other location - About 40 mins to fix
app/loading.tsx on lines 5..11

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function POST has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export async function POST(req: NextRequest) {
  const headersList = headers();
  const ip = headersList.get("x-forwarded-for") ?? "127.0.0.1";

  const { success, reset } = await ratelimit.limit(ip);
Severity: Minor
Found in app/api/score/route.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return NextResponse.json(error, { status: 500 });
Severity: Major
Found in app/api/score/route.ts - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return NextResponse.json(dbEntry, { status: 200, statusText: "OK" });
Severity: Major
Found in app/api/score/route.ts - About 30 mins to fix

Function EndGameInput has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

const EndGameInput: React.FC<TEndGameInput> = ({
  final_score,
  gameStartTime,
  gameEndTime,
}) => {
Severity: Minor
Found in components/game/end-game-input.tsx - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language