Sign upLogin

kfriars/laravel-translations-manager

View on GitHub
Star

Showing 18 of 18 total issues

Method validateTranslations has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function validateTranslations(string $langFile, string $referenceLocale, string $locale): array
    {
        if (! $this->translator->has($langFile, $locale)) {
            return [new Error(
                $locale,
Severity: Minor
Found in src/TranslationsValidator.php - About 1 hr to fix

    Function recursiveReplaceKey has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function recursiveReplaceKey(
        string $key,
        $translation,
        array &$healing,
        array &$lockfile,
    Severity: Minor
    Found in src/TranslationsFixer.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function recursiveValidateTranslations has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function recursiveValidateTranslations(
        array $reference,
        array $dependent,
        array $lockfile,
        string $keyPath = '',
    Severity: Minor
    Found in src/TranslationsValidator.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method recursiveReplaceKey has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function recursiveReplaceKey(
        string $key,
        $translation,
        array &$healing,
        array &$lockfile,
    Severity: Minor
    Found in src/TranslationsFixer.php - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php

namespace Kfriars\TranslationsManager\Commands;

use Illuminate\Console\Command;
      Severity: Major
      Found in src/Commands/TranslationsUnignoreCommand.php and 1 other location - About 1 hr to fix
      src/Commands/TranslationsIgnoreCommand.php on lines 1..29

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php

namespace Kfriars\TranslationsManager\Commands;

use Illuminate\Console\Command;
      Severity: Major
      Found in src/Commands/TranslationsIgnoreCommand.php and 1 other location - About 1 hr to fix
      src/Commands/TranslationsUnignoreCommand.php on lines 1..29

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method recursiveValidateTranslations has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function recursiveValidateTranslations(
        array $reference,
        array $dependent,
        array $lockfile,
        string $keyPath = '',
      Severity: Minor
      Found in src/TranslationsValidator.php - About 1 hr to fix

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                ConfigContract $config,
        FormatterContract $formatter,
        ArrayFileContract $arrayFile,
        FixesValidatorContract $validator,
        LockfilesContract $lockfiles,
        Severity: Minor
        Found in src/TranslationsFixer.php - About 45 mins to fix

          Method makeReferenceAssertions has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  array $reference,
        array $dependent,
        array $locked,
        string $keyPath,
        array &$errors
          Severity: Minor
          Found in src/TranslationsValidator.php - About 35 mins to fix

            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    string $locale,
        string $file,
        string $key,
        string $message,
        bool $ignored
            Severity: Minor
            Found in src/Entities/Error.php - About 35 mins to fix

              Method recursiveReplaceKey has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      string $key,
        $translation,
        array &$healing,
        array &$lockfile,
        array $reference
              Severity: Minor
              Found in src/TranslationsFixer.php - About 35 mins to fix

                Method recursiveValidateTranslations has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        array $reference,
        array $dependent,
        array $lockfile,
        string $keyPath = '',
        array &$errors = []
                Severity: Minor
                Found in src/TranslationsValidator.php - About 35 mins to fix

                  Function recursiveRemoveKey has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function recursiveRemoveKey(array &$translations, string $key): void
    {
        if (isset($translations[$key])) {
            unset($translations[$key]);
                  Severity: Minor
                  Found in src/TranslationsFixer.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function recursiveValidateKey has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function recursiveValidateKey(string $key, array $reference): bool
    {
        // Check if we have a full match of the key in the reference locale
        if (isset($reference[$key])) {
            return false;
                  Severity: Minor
                  Found in src/TranslationsFixesValidator.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function makeReferenceAssertions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function makeReferenceAssertions(
        array $reference,
        array $dependent,
        array $locked,
        string $keyPath,
                  Severity: Minor
                  Found in src/TranslationsValidator.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function clean has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function clean(ListingContract $listing): int
    {
        $dead = $listing->errors()
                        ->where('message', Error::NO_REFERENCE_TRANSLATION);
                  Severity: Minor
                  Found in src/TranslationsFixer.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function onlyOneFixFilePerLocale has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function onlyOneFixFilePerLocale(array $locales, array $files): array
    {
        $unique = [];

        foreach ($files as $filepath) {
                  Severity: Minor
                  Found in src/TranslationsFixesValidator.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function hasErrors has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function hasErrors(bool $ignore = true): bool
    {
        if ($ignore && $this->ignored) {
            return false;
        }
                  Severity: Minor
                  Found in src/Entities/TranslationsFile.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language