Sign upLogin

khalyomede/gridsome-plugin-service-worker

View on GitHub
Star

Showing 26 of 26 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private _addNetworkFirstToServiceWorkerContent(): void {
        if (
            "networkFirst" in this._options &&
            this._options.networkFirst instanceof Object &&
            (this._options.networkFirst.routes.length > 0 ||
Severity: Major
Found in src/gridsome.server.ts and 1 other location - About 1 day to fix
src/gridsome.server.ts on lines 178..230

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 296.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private _addCacheFirstToServiceWorkerContent(): void {
        if (
            "cacheFirst" in this._options &&
            this._options.cacheFirst instanceof Object &&
            (this._options.cacheFirst.routes.length > 0 ||
Severity: Major
Found in src/gridsome.server.ts and 1 other location - About 1 day to fix
src/gridsome.server.ts on lines 285..337

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 296.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private _addCacheOnlyToServiceWorkerContent(): void {
        if (
            "cacheOnly" in this._options &&
            this._options.cacheOnly instanceof Object &&
            (this._options.cacheOnly.routes.length > 0 ||
Severity: Major
Found in src/gridsome.server.ts and 2 other locations - About 1 day to fix
src/gridsome.server.ts on lines 339..390
src/gridsome.server.ts on lines 392..443

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 287.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private _addNetworkOnlyToServiceWorkerContent(): void {
        if (
            "networkOnly" in this._options &&
            this._options.networkOnly instanceof Object &&
            (this._options.networkOnly.routes.length > 0 ||
Severity: Major
Found in src/gridsome.server.ts and 2 other locations - About 1 day to fix
src/gridsome.server.ts on lines 232..283
src/gridsome.server.ts on lines 392..443

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 287.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private _addStaleWhileRevalidateToServiceWorkerContent(): void {
        if (
            "staleWhileRevalidate" in this._options &&
            this._options.staleWhileRevalidate instanceof Object &&
            (this._options.staleWhileRevalidate.routes.length > 0 ||
Severity: Major
Found in src/gridsome.server.ts and 2 other locations - About 1 day to fix
src/gridsome.server.ts on lines 232..283
src/gridsome.server.ts on lines 339..390

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 287.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File gridsome.server.ts has 570 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as commonjs from "@rollup/plugin-commonjs";
import nodeResolve from "@rollup/plugin-node-resolve";
import * as replace from "@rollup/plugin-replace";
import { generate } from "escodegen";
import { readFileSync, unlinkSync, writeFileSync } from "fs";
Severity: Major
Found in src/gridsome.server.ts - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private static async _transpileAndSaveServiceWorkerRegistration(): Promise<
        void
    > {
        const serviceWorkerRegistrationBundle = await rollup({
            input: "./static/register-service-worker.temp.js",
    Severity: Major
    Found in src/gridsome.server.ts and 1 other location - About 6 hrs to fix
    src/gridsome.server.ts on lines 452..495

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 158.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private static async _transpileAndSaveServiceWorker(): Promise<void> {
        const serviceWorkerBundle = await rollup({
            input: "./static/service-worker.temp.js",
            plugins: [
                /**
    Severity: Major
    Found in src/gridsome.server.ts and 1 other location - About 6 hrs to fix
    src/gridsome.server.ts on lines 497..542

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 158.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _throwIfOptionIsNotAStrategy has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

        private _throwIfOptionIsNotAStrategy(
        optionName:
            | "cacheFirst"
            | "networkFirst"
            | "cacheOnly"
    Severity: Minor
    Found in src/gridsome.server.ts - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _throwIfOptionIsNotAStrategy has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private _throwIfOptionIsNotAStrategy(
        optionName:
            | "cacheFirst"
            | "networkFirst"
            | "cacheOnly"
    Severity: Major
    Found in src/gridsome.server.ts - About 2 hrs to fix

      GridsomePluginServiceWorker has 22 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class GridsomePluginServiceWorker {
    private readonly _options: IOptions;
    private _serviceWorkerContent: string;
    private _serviceWorkerRegistrationContent: string;
    public readonly ALLOWED_REQUEST_DESTINATION = [
      Severity: Minor
      Found in src/gridsome.server.ts - About 2 hrs to fix

        Function _addNetworkFirstToServiceWorkerContent has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private _addNetworkFirstToServiceWorkerContent(): void {
        if (
            "networkFirst" in this._options &&
            this._options.networkFirst instanceof Object &&
            (this._options.networkFirst.routes.length > 0 ||
        Severity: Minor
        Found in src/gridsome.server.ts - About 1 hr to fix

          Function _addCacheFirstToServiceWorkerContent has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private _addCacheFirstToServiceWorkerContent(): void {
        if (
            "cacheFirst" in this._options &&
            this._options.cacheFirst instanceof Object &&
            (this._options.cacheFirst.routes.length > 0 ||
          Severity: Minor
          Found in src/gridsome.server.ts - About 1 hr to fix

            Function _addNetworkOnlyToServiceWorkerContent has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private _addNetworkOnlyToServiceWorkerContent(): void {
        if (
            "networkOnly" in this._options &&
            this._options.networkOnly instanceof Object &&
            (this._options.networkOnly.routes.length > 0 ||
            Severity: Minor
            Found in src/gridsome.server.ts - About 1 hr to fix

              Function _addCacheOnlyToServiceWorkerContent has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private _addCacheOnlyToServiceWorkerContent(): void {
        if (
            "cacheOnly" in this._options &&
            this._options.cacheOnly instanceof Object &&
            (this._options.cacheOnly.routes.length > 0 ||
              Severity: Minor
              Found in src/gridsome.server.ts - About 1 hr to fix

                Function _addStaleWhileRevalidateToServiceWorkerContent has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private _addStaleWhileRevalidateToServiceWorkerContent(): void {
        if (
            "staleWhileRevalidate" in this._options &&
            this._options.staleWhileRevalidate instanceof Object &&
            (this._options.staleWhileRevalidate.routes.length > 0 ||
                Severity: Minor
                Found in src/gridsome.server.ts - About 1 hr to fix

                  Function constructor has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public constructor(api: IApi, options: IOptions) {
        this._options = options;
        this._serviceWorkerContent = "";
        this._serviceWorkerRegistrationContent = "";
                  Severity: Minor
                  Found in src/gridsome.server.ts - About 1 hr to fix

                    Function defaultOptions has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static defaultOptions(): IOptions {
        return {
            cacheFirst: {
                cacheName: "cf-v1",
                routes: [],
                    Severity: Minor
                    Found in src/gridsome.server.ts - About 1 hr to fix

                      Function _transpileAndSaveServiceWorker has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private static async _transpileAndSaveServiceWorker(): Promise<void> {
        const serviceWorkerBundle = await rollup({
            input: "./static/service-worker.temp.js",
            plugins: [
                /**
                      Severity: Minor
                      Found in src/gridsome.server.ts - About 1 hr to fix

                        Function _transpileAndSaveServiceWorkerRegistration has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private static async _transpileAndSaveServiceWorkerRegistration(): Promise<
        void
    > {
        const serviceWorkerRegistrationBundle = await rollup({
            input: "./static/register-service-worker.temp.js",
                        Severity: Minor
                        Found in src/gridsome.server.ts - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language