Sign upLogin

khalyomede/gulp-revisioner

View on GitHub
Star

Showing 5 of 5 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if ("manifestName" in options) {
        if (!isString(options.manifestName)) {
            return new TypeError("Expected options.manifestName to be a String.");
        }
    } else {
Severity: Minor
Found in src/parse-options.ts and 1 other location - About 45 mins to fix
src/parse-options.ts on lines 20..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if ("baseUrl" in options) {
        if (!isString(options.baseUrl)) {
            return new TypeError("Expected options.baseUrl to be a String.");
        }
    } else {
Severity: Minor
Found in src/parse-options.ts and 1 other location - About 45 mins to fix
src/parse-options.ts on lines 36..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return parsedOptions;
Severity: Major
Found in src/parse-options.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return new TypeError("Expected options.eraseBeforeWriting to be a Boolean.");
    Severity: Major
    Found in src/parse-options.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return new TypeError("Expected options.indentSize to be an integer Number.");
      Severity: Major
      Found in src/parse-options.ts - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language