khalyomede/laravel-seed

View on GitHub

Showing 4 of 4 total issues

SeedMake has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class SeedMake extends Command
{
    use CapableOfRunningSeeds;

    protected $signature = "seed:make {name : The name of the seeder. Can have sub folders in the name.} {--f|force : Will erase any existing file.} {--m|model= : The model into which to seed data.}";
Severity: Minor
Found in src/Commands/SeedMake.php - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private function getSeederClassName(): string
        {
            $matches = [];
            $succeeded = preg_match("/\d+_\d+_\d+_\d+_([\w_]+)$/", $this->seedFileName, $matches);
    
    
    Severity: Major
    Found in src/Traits/CapableOfRunningSeeds.php and 1 other location - About 1 hr to fix
    src/Commands/Seed.php on lines 108..122

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private function getSeederClassName(): string
        {
            $matches = [];
            $succeeded = preg_match("/\d+_\d+_\d+_\d+_([\w_]+)$/", $this->seedFileName, $matches);
    
    
    Severity: Major
    Found in src/Commands/Seed.php and 1 other location - About 1 hr to fix
    src/Traits/CapableOfRunningSeeds.php on lines 23..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method handle has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function handle()
        {
            $this->batchNumber = Seeder::getNextBatchNumber();
    
            $seedFileNames = $this->getSeedFiles();
    Severity: Minor
    Found in src/Commands/Seed.php - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language