khiav223577/deep_pluck

View on GitHub
lib/deep_pluck/data_combiner.rb

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Method assign_values_to_parent has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def assign_values_to_parent(collection, parent, children_hash, column_name, foreign_key, reverse: false)
        parent.each do |s|
          next if (id = s[foreign_key]) == nil
          left = reverse ? children_hash[id] : s
          right = !reverse ? children_hash[id] : s
Severity: Minor
Found in lib/deep_pluck/data_combiner.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method combine_data has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def combine_data(parent, children, primary_key, column_name, foreign_key, reverse, collection)
Severity: Major
Found in lib/deep_pluck/data_combiner.rb - About 50 mins to fix

    Method assign_values_to_parent has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def assign_values_to_parent(collection, parent, children_hash, column_name, foreign_key, reverse: false)
    Severity: Minor
    Found in lib/deep_pluck/data_combiner.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status