Sign upLogin

killbill/killbill-client-ruby

View on GitHub
Star
lib/killbill_client/api/net_http_adapter.rb

Summary

Maintainability
D
1 day
Test Coverage

Method request has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

        def request(method, relative_uri, options = {})
          head = headers.dup
          head.update options[:head] if options[:head]
          head.delete_if { |_, value| value.nil? }
Severity: Minor
Found in lib/killbill_client/api/net_http_adapter.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method request has 109 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def request(method, relative_uri, options = {})
          head = headers.dup
          head.update options[:head] if options[:head]
          head.delete_if { |_, value| value.nil? }
Severity: Major
Found in lib/killbill_client/api/net_http_adapter.rb - About 4 hrs to fix

    Method build_uri has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

            def build_uri(relative_uri, options)
          # Need to encode in case of spaces (e.g. /1.0/kb/security/users/Mad Max/roles)
          encoded_relative_uri = URI::DEFAULT_PARSER.escape(relative_uri)
          if URI(encoded_relative_uri).scheme.nil?
            uri = (options[:base_uri] || KillBillClient::API.base_uri)
    Severity: Minor
    Found in lib/killbill_client/api/net_http_adapter.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method encode_params has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def encode_params(options = {})
          # Plugin properties and controlPluginNames are passed in the options but we want to send them as query parameters,
          # so remove with from global hash and insert them under :params
          plugin_properties = options.delete :pluginProperty
          if plugin_properties && plugin_properties.size > 0
    Severity: Minor
    Found in lib/killbill_client/api/net_http_adapter.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

              if (options[:api_key] || KillBillClient.api_key) && (options[:api_secret] || KillBillClient.api_secret)
            request['X-Killbill-ApiKey'] = options[:api_key] || KillBillClient.api_key
            request['X-Killbill-ApiSecret'] = options[:api_secret] || KillBillClient.api_secret
          end
    Severity: Major
    Found in lib/killbill_client/api/net_http_adapter.rb - About 40 mins to fix

      Method create_http_client has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def create_http_client(uri, options = {})
          http = ::Net::HTTP.new uri.host, uri.port
          if options[:read_timeout].is_a? Numeric
            http.read_timeout = options[:read_timeout].to_f / 1000
          elsif KillBillClient.read_timeout.is_a? Numeric
      Severity: Minor
      Found in lib/killbill_client/api/net_http_adapter.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                if options[:connection_timeout].is_a? Numeric
            http.open_timeout = options[:connection_timeout].to_f / 1000
          elsif KillBillClient.connection_timeout.is_a? Numeric
            http.open_timeout = KillBillClient.connection_timeout.to_f / 1000
          end
      Severity: Minor
      Found in lib/killbill_client/api/net_http_adapter.rb and 1 other location - About 15 mins to fix
      lib/killbill_client/api/net_http_adapter.rb on lines 89..93

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                if options[:read_timeout].is_a? Numeric
            http.read_timeout = options[:read_timeout].to_f / 1000
          elsif KillBillClient.read_timeout.is_a? Numeric
            http.read_timeout = KillBillClient.read_timeout.to_f / 1000
          end
      Severity: Minor
      Found in lib/killbill_client/api/net_http_adapter.rb and 1 other location - About 15 mins to fix
      lib/killbill_client/api/net_http_adapter.rb on lines 94..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status